tests: core functionality #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

godzillaba merged 6 commits into wa/master-vault-isolated from ybb/migrate-tests

Dec 23, 2025

Merged

tests: core functionality #140

MasterVault reserve (#141)

GitHub Advanced Security / Slither succeeded Dec 23, 2025 in 3s

4 new alerts including 4 medium severity security vulnerabilities

New alerts in code changed by this pull request

Security Alerts:

4 medium

See annotations below for details.

View all branch alerts.

Annotations

Check warning on line 228 in contracts/tokenbridge/libraries/vault/MasterVault.sol

Code scanning / Slither

Unused return Medium

MasterVault._rebalance() ignores return value by subVault.withdraw(assetsToWithdraw,address(this),address(this))

Check warning on line 228 in contracts/tokenbridge/libraries/vault/MasterVault.sol

Code scanning / Slither

Unused return Medium

MasterVault._rebalance() ignores return value by subVault.deposit(assetsToDeposit,address(this))

Check warning on line 254 in contracts/tokenbridge/libraries/vault/MasterVault.sol

Code scanning / Slither

Dangerous strict equalities Medium

MasterVault._distributePerformanceFee() uses a dangerous strict equality:
- profit == 0

Check warning on line 254 in contracts/tokenbridge/libraries/vault/MasterVault.sol

Code scanning / Slither

Unused return Medium

MasterVault._distributePerformanceFee() ignores return value by subVault.withdraw(amountToWithdraw,beneficiary,address(this))