Add verification of deterministic deployments #145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TucksonDev
commented
Dec 18, 2025
| } | ||
|
|
||
| // Helper function to encode constructor arguments based on their types | ||
| function abiEncodeConstructorArguments(args: any[]): string { |
Contributor
Author
There was a problem hiding this comment.
Crafted this function to avoid having to pass the types of arguments for verification.
TucksonDev
commented
Dec 18, 2025
| readonly contractToSource = { | ||
| l1TokenBridgeCreatorProxyAdmin: this.PROXY_ADMIN, | ||
| l1TokenBridgeCreatorLogic: | ||
| ProxyAdmin: this.PROXY_ADMIN, |
Contributor
Author
There was a problem hiding this comment.
Changed the keys of this object to use directly the name of the contract instead of custom keys (since these are not used anymore in the calling function)
godzillaba
reviewed
Dec 22, 2025
| } | ||
|
|
||
| // Helper function to encode constructor arguments based on their types | ||
| function abiEncodeConstructorArguments(args: any[]): string { |
godzillaba
approved these changes
Dec 22, 2025
Contributor
godzillaba
left a comment
godzillaba
left a comment
There was a problem hiding this comment.
LGTM besides the one comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on top of #144 , updating the verification of the deployed contracts, so it's all encapsulated at the end of the deployment process.
All verification functions are part of the ContractVerifier class, which manages queuing verification requests and triggering them all at once.
This PR is a cleaner version of #115