Skip to content

[scripts] Update tests to no longer use Node 20 #1344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlexJerabek merged 2 commits into from
Apr 29, 2026
+7 −7
Merged

[scripts] Update tests to no longer use Node 20 #1344

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e3e62dd
Update tests to no longer use Node 20
AlexJerabek Apr 29, 2026
5b10989
Merge branch 'main' into AlexJ-Node20
ElizabethSamuel-MSFT Apr 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
strategy:
fail-fast: false
matrix:
node-version: ['20', '22', '24']
node-version: ['22', '24']

steps:
- name: Checkout code
Expand Down
12 changes: 6 additions & 6 deletions scripts/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ This suite provides automated build testing for all Office Add-in samples. Tests

**What happens:** When your PR triggers testing, the following occurs:

1. Tests run against Node.js 20, 22, and 24 (in parallel).
1. Tests run against Node.js 22 and 24 (in parallel).
1. A bot posts results to your PR (~15-20 minutes).
1. ✅ Green check = All builds passed or failed as expected.
1. ❌ Red X = An unexpected build failure occurred and needs fixing.
Expand Down Expand Up @@ -227,7 +227,7 @@ For detailed examples, see the main repository.

### Prerequisites

- **Node.js** (version 20, 22, or 24)
- **Node.js** (version 22 or 24)
- **jq** - JSON processor
- Ubuntu/Debian: `sudo apt-get install jq`
- macOS: `brew install jq`
Expand Down Expand Up @@ -295,7 +295,7 @@ cat build-logs/Samples_excel-data-types-explorer.log

**Node version problems:**

- Matrix tests Node 20, 22, 24.
- Matrix tests Node 22 and 24.
- Ensure `package.json` has compatible engine requirements.

---
Expand All @@ -304,7 +304,7 @@ cat build-logs/Samples_excel-data-types-explorer.log

**Typical run times:**

- Per PR: About 15-20 minutes (three Node versions in parallel)
- Per PR: About 15-20 minutes (two Node versions in parallel)
- Per Node version: About 10-15 minutes
- With cache hit: About 8-12 minutes
- Single sample: About 15-30 seconds
Expand All @@ -317,7 +317,7 @@ cat build-logs/Samples_excel-data-types-explorer.log
**Optimization:**

- npm cache reuses downloads across samples
- Parallel matrix testing (three jobs run simultaneously)
- Parallel matrix testing (two jobs run simultaneously)
- Individual logs capture install/build output for all samples

---
Expand All @@ -332,7 +332,7 @@ cat build-logs/Samples_excel-data-types-explorer.log

### Workflow features

- **Matrix testing**: Node.js 20, 22, 24
- **Matrix testing**: Node.js 22, 24
- **Smart caching**: npm downloads with restore keys
- **Artifact upload**: Results and logs with 30-day retention
- **PR comments**: Auto-posted summaries
Expand Down
Loading