[Word] Add snippets for APIs re pages, panes, windows#974
Merged
ElizabethSamuel-MSFT merged 6 commits intomainfrom Apr 23, 2025
Merged
[Word] Add snippets for APIs re pages, panes, windows#974ElizabethSamuel-MSFT merged 6 commits intomainfrom
ElizabethSamuel-MSFT merged 6 commits intomainfrom
Conversation
AlexJerabek
requested changes
Apr 7, 2025
|
|
||
| const pages: Word.PageCollection = rangeOfParagraph.pages; | ||
| pages.load(); | ||
| await context.sync(); |
Collaborator
There was a problem hiding this comment.
Do we really need three roundtrips to the document before even getting to the API in question? If so, that seems like a product flaw.
| for (let i = 0; i < pages.items.length; i++) { | ||
| let page = pages.items[i]; | ||
| page.load(); | ||
| await context.sync(); |
Collaborator
There was a problem hiding this comment.
We should avoid doing load/sync in a loop. It's a bad pattern. This article has some tips to avoid that: https://learn.microsoft.com/en-us/office/dev/add-ins/concepts/correlated-objects-pattern
Co-authored-by: Alex Jerabek <38896772+AlexJerabek@users.noreply.github.com>
AlexJerabek
approved these changes
Apr 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Will do object mapping later