Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor log.fnl to remove aniseed nvim module #636

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

saccarosium
Copy link
Contributor

Ok this is a revised #634. It shouldn't have any regressions

Copy link
Owner

@Olical Olical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just going to try it locally first. Sorry this took so long!

(tset vim.wo win :foldmarker (.. (config.get-in [:log :fold :marker :start])
","
(config.get-in [:log :fold :marker :end])))
(tset vim.wo win :foldlevel 0))
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh this is very neat.

@@ -515,10 +504,9 @@
(on-new-log-buf (upsert-buf)))

(fn reset-hard []
(nvim.ex.bwipeout_ (upsert-buf)))
(vim.api.nvim_buf_delete (upsert-buf) {:force true}))
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh this is equivalent? Interesting!

@Olical Olical merged commit 1b4b1f6 into Olical:main Jan 15, 2025
3 checks passed
@Olical
Copy link
Owner

Olical commented Jan 15, 2025

Works fine 🎉

@saccarosium
Copy link
Contributor Author

Yes now a lot of equivalents for the viml functions are available through the vim.api.*. Also there are interesting table to interact with {window,buffer,global} options that makes code a bit more concise.

I will be back...

@saccarosium saccarosium deleted the refactor-log branch January 15, 2025 21:44
@Olical
Copy link
Owner

Olical commented Jan 15, 2025

Sweet, well thank you for sharing and upgrading the code 😄 this is very much appreciated, thank you for your efforts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants