fix: convert URL string to NSURL before passing to setURL_#24
Open
XuanyouLiu wants to merge 1 commit intoOmar-V2:mainfrom
Open
fix: convert URL string to NSURL before passing to setURL_#24XuanyouLiu wants to merge 1 commit intoOmar-V2:mainfrom
XuanyouLiu wants to merge 1 commit intoOmar-V2:mainfrom
Conversation
EKEvent.setURL_() expects an NSURL object, but a Python string was being passed directly via PyObjC. This caused an NSInvalidArgumentException: [OC_BuiltinPythonUnicode absoluteString]: unrecognized selector Fix by importing Foundation.NSURL and wrapping the URL string with NSURL.URLWithString_() in both create_event and update_event paths. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #23
EKEvent.setURL_()expects anNSURLobject, but a plain Python string was being passed, causingNSInvalidArgumentException: [OC_BuiltinPythonUnicode absoluteString]: unrecognized selectorNSURLfromFoundationand wrap URL strings withNSURL.URLWithString_()in bothcreate_eventandupdate_eventcode pathsChanges
src/mcp_ical/ical.py:from Foundation import NSURLimportekevent.setURL_(new_event.url)toekevent.setURL_(NSURL.URLWithString_(new_event.url))(create path)existing_ek_event.setURL_(request.url)toexisting_ek_event.setURL_(NSURL.URLWithString_(request.url))(update path)Test plan
Made with Cursor