Add missing DMA header file.#245
Add missing DMA header file.#245lihuanhuan merged 1 commit intoOneKeyHQ:mainfrom lihuanhuan:pro_main
Conversation
WalkthroughThis pull request adds a new header file that defines DMA configuration for UART4 and SPI2 peripherals. The file contains macro definitions for DMA streams, request identifiers, NVIC interrupt numbers, and interrupt handlers used in DMA operations. These changes standardize the setup of DMA channels for both UART and SPI on STMicroelectronics' BLE components. Changes
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
core/embed/trezorhal/dma_channel.h (2)
18-18: Remove redundant comments.These comments restate the obvious.
-/* Definition for SPIx's DMA */ -/* Definition for SPIx's NVIC */Also applies to: 25-25
33-33: Add newline at end of file.Missing newline character.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
core/embed/trezorhal/dma_channel.h(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Gen check
- GitHub Check: Defs check
- GitHub Check: Style check
Summary by CodeRabbit