Fix camera reopening failure.

[lihuanhuan]

Summary by CodeRabbit

• Bug Fixes
  • Improved camera operation reliability with new readiness checks that ensure proper configuration before capturing images.
  • Enhanced error handling by now indicating capture success or failure.
• Refactor
  • Streamlined the image capture flow in QR code processing for more robust and dependable functionality.

[coderabbitai]

Walkthrough

The update changes the camera capture and power functions to include additional error checks. The signature of camera_capture_start is modified from void to bool to indicate success or failure. A check now verifies camera configuration before starting capture, and an online check is added in camera_power_on. In addition, the QR code decoding function now uses the updated capture function to manage the initiation process.

Changes

File(s)	Change Summary
core/.../camera.c, core/.../camera.h	Updated camera_capture_start signature from void to bool. In camera.c, added a check for camera configuration and an online check in camera_power_on.
core/.../camera_qrcode.c	Modified camera_qr_decode control flow by replacing the direct online check with a call to camera_capture_start, and removed the redundant capture call.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d4e50f9 and 8f19097.

📒 Files selected for processing (3)

• core/embed/trezorhal/camera.c (2 hunks)
• core/embed/trezorhal/camera.h (1 hunks)
• core/embed/trezorhal/camera_qrcode.c (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (3)

• GitHub Check: Defs check
• GitHub Check: Gen check
• GitHub Check: Style check

🔇 Additional comments (4)

core/embed/trezorhal/camera_qrcode.c (1)

135-138: LGTM!

The change improves error handling by using the updated camera_capture_start function.

core/embed/trezorhal/camera.c (2)

269-282: LGTM!

The function now properly validates camera configuration before starting capture.

---

346-349: LGTM!

The function now verifies camera is online after power-on.

core/embed/trezorhal/camera.h (1)

36-36: LGTM!

The function signature now correctly reflects the return type.

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.