Skip to content

[Snyk] Security upgrade eslint from 8.27.0 to 10.0.0#114

Open
revan-zhang wants to merge 1 commit intomainfrom
snyk-fix-a69e1a5b17f5b60b858613d72dd693ab
Open

[Snyk] Security upgrade eslint from 8.27.0 to 10.0.0#114
revan-zhang wants to merge 1 commit intomainfrom
snyk-fix-a69e1a5b17f5b60b858613d72dd693ab

Conversation

@revan-zhang
Copy link
Copy Markdown
Contributor

@revan-zhang revan-zhang commented Mar 29, 2026

snyk-top-banner

Snyk has created this PR to fix 1 vulnerabilities in the yarn dependencies of this project.

Snyk changed the following file(s):

  • package.json
  • yarn.lock

Note for zero-installs users

If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.

Vulnerabilities that will be fixed with an upgrade:

Issue Score
high severity Infinite loop
SNYK-JS-BRACEEXPANSION-15789759
  555  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.


Open with Devin

Note

Medium Risk
Upgrades core lint tooling (eslint v8→v10) and rewrites parts of the dependency tree, which may cause new lint rule/CLI/config incompatibilities in CI or local dev.

Overview
Updates eslint from ^8.23.1 to ^10.0.0 in package.json as part of a security-driven dependency upgrade.

Refreshes yarn.lock to the new ESLint v10 dependency graph (notably pulling in newer minimatch/brace-expansion and related packages) to remediate the reported vulnerability.

Written by Cursor Bugbot for commit 238d95d. This will update automatically on new commits. Configure here.

@revan-zhang
Copy link
Copy Markdown
Contributor Author

revan-zhang commented Mar 29, 2026

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@socket-security
Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatedeslint@​8.27.0 ⏵ 10.1.089100100 +196 +46100

View full report

Copy link
Copy Markdown

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

View 2 additional findings in Devin Review.

Open in Devin Review

"dotenv": "^10.0.0",
"dotenv-expand": "^5.1.0",
"eslint": "^8.23.1",
"eslint": "^10.0.0",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 ESLint major version bump to v10 breaks all linting due to incompatible legacy .eslintrc config and ESLint 8-era plugins

ESLint is bumped from ^8.23.1 to ^10.0.0 (resolving to 10.1.0 in the lockfile), but the project relies entirely on the legacy .eslintrc configuration format (.eslintrc:1-37) and the eslintConfig field in package.json:179-181. ESLint 9 deprecated .eslintrc support, and ESLint 10 removed it entirely — only flat config (eslint.config.js) is supported. Additionally, all ESLint plugins and configs are pinned to ESLint 8-compatible versions (e.g., @typescript-eslint/eslint-plugin: ^5.38.0, @typescript-eslint/parser: ^5.38.0, eslint-config-wesbos: ^3.0.2, eslint-plugin-react-hooks: ^4.6.0, eslint-config-react-app: ^7.0.1), which have peer dependencies on ESLint 8 and use the legacy plugin API. This will cause yarn lint, yarn lint:fix, and the eslint-webpack-plugin integration during yarn start/yarn build to fail.

Suggested change
"eslint": "^10.0.0",
"eslint": "^8.23.1",
Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

"dotenv": "^10.0.0",
"dotenv-expand": "^5.1.0",
"eslint": "^8.23.1",
"eslint": "^10.0.0",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESLint 10 breaks project's legacy eslintrc configuration

High Severity

Upgrading eslint from ^8.23.1 to ^10.0.0 will break linting entirely. ESLint 10 completely removed support for the legacy eslintrc configuration format, but this project defines its ESLint config via the eslintConfig field in package.json (using "extends": "react-app"), which is the legacy format. Additionally, all companion packages (eslint-config-airbnb, eslint-config-react-app, eslint-config-prettier, eslint-config-airbnb-typescript, eslint-config-wesbos, eslint-webpack-plugin, etc.) are pinned to versions that only support ESLint 8's legacy config and declare eslint@^8 as a peer dependency. The lint and lint:fix scripts will fail, and the webpack build may also break since eslint-webpack-plugin is configured.

Additional Locations (1)
Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants