Skip to content

fix(legacy): fix ada message sign issue #594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
somebodyLi merged 2 commits into from
May 7, 2025
Merged

fix(legacy): fix ada message sign issue #594

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca76b2d
fix(legacy): fix ada message sign issue
somebodyLi May 7, 2025
648401a
fix(legacy): add evm chain FTM
somebodyLi May 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions legacy/firmware/ada.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,8 +382,7 @@ bool ada_get_address(const CardanoGetAddress *msg, char *address) {
int address_bytes_len = 0;
memset(&ada_node, 0, sizeof(HDNode));
if (!config_getCardanoRootNode(&ada_node)) {
fsm_sendFailure(FailureType_Failure_ProcessError,
_("Deriving root failed"));
fsm_sendFailure(FailureType_Failure_ProcessError, "Deriving root failed");
return false;
}
if (!derive_bytes(&msg->address_parameters, msg->network_id,
Expand Down Expand Up @@ -1963,6 +1962,10 @@ bool ada_sign_messages(const CardanoSignMessage *msg,
memcpy(address_params.address_n_staking, staking_path,
address_params.address_n_staking_count * sizeof(uint32_t));
}
if (!config_getCardanoRootNode(&ada_node)) {
fsm_sendFailure(FailureType_Failure_ProcessError, "Deriving root failed");
return false;
}
if (!derive_bytes(&address_params, msg->network_id, MAINNET_PROTOCOL_MAGIC,
address_bytes, &address_bytes_len)) {
return false;
Expand Down
3 changes: 3 additions & 0 deletions legacy/firmware/ethereum_onekey.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,9 @@ bool ethereum_parse_onekey(const char *address, uint8_t pubkeyhash[20]);
case 137: \
chain_name = "Polygon"; \
break; \
case 250: \
chain_name = "Fantom"; \
break; \
case 324: \
chain_name = "zkSync Era"; \
break; \
Expand Down
Loading