Line following improvements #132
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnselChang
requested changes
Aug 23, 2023
| .. tab-item:: Blockly | ||
|
|
||
| .. image:: media/set_error.png |
| Let's do a quick check to make sure the code makes sense. We assume base_effort | ||
| = 0.5 and KP = 1. If the reflectance reads whitish-grey and yields a value of | ||
| around 0.25, the error would be -0.25, meaning that the left motor's effort is: | ||
| .. code-block:: python |
| .. tab-item:: Blockly | ||
|
|
||
| .. image:: media/one_edge_line_follow.png |
|
|
||
| Just to review, let's take this code line-by-line and make sure we understand what's going on. | ||
|
|
||
| :code:`threshold = 0.5` sets the threshold value to 0.5. |
There was a problem hiding this comment.
Would rather not, i think it's intuitive enough to be able to compare side by side - using sphinx to do inline images is really tedious
AnselChang
requested changes
Sep 7, 2023
|
Made all non-blockly related changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General wording and explanation improvements.
Fixes #66, #74, #75, and #76.
One sensor proportional control still needs video.