-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bumped up Dart min version to 3.0.0 for json_serializable #20493
base: master
Are you sure you want to change the base?
Bumped up Dart min version to 3.0.0 for json_serializable #20493
Conversation
thanks for the PR please follow step 3 to update the samples. |
…on_serializable requires Dart 3.5 since 6.9.0
9a54601
to
6788e45
Compare
@wing328, thank you. I've updated samples in PR. |
@@ -4,7 +4,7 @@ description: OpenAPI API client | |||
homepage: homepage | |||
|
|||
environment: | |||
sdk: '>=2.17.0 <4.0.0' | |||
sdk: '>=3.0.0 <4.0.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the PR
does it mean the output (dart API client) no longer work with Dart 2.x?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. I use json_serializable as serializationLibrary and I see error when I try to generate code via dart run build_runner build
with json_serializable:6.9.0. Here is example of error:
line 18, column 30 of .: Expected to find ')'.
╷
18 │ if (instance.message case final value?) 'message': value,
│ ^^^^
╵
json_serializable generates code with case clauses in if statements since 6.9.0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what about adding an option supportDart2
(default to false) for backward compatibility?
we can't ship a change that breaks all Dart 2.x users.
Bumped up Dart min version to 3.0.0 for json_serializable, because json_serializable requires Dart 3.5 since 6.9.0.
Error out about bump up Dart version has been added to json_serializable release 6.9.3
@jaumard @josh-burton @amondnet @sbu-WBT @kuhnroyal @agilob @ahmednfwela, could you review my PR?
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming7.x.0
minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)