[Go] skip validator import if oneOf discriminator lookup is enabled #20497
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Go generator produces invalid code for
oneOf
models that have discriminators whenuseOneOfDiscriminatorLookup
is set totrue
. In this case, the model importsgopkg.in/validator.v2
but does not use it because validation is skipped when discriminator lookup is enabled.This updates the Go generator so that the validator import is skipped if discriminator lookup is enabled. In order to make this change I had to move the validator import from
AbstractGoCodegen
toGoClientCodegen
; this is a safe change because theoneOf
validation code only exists in the Go client generator templates, not in the other Go generators.PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming7.x.0
minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)@wing328