-
-
Notifications
You must be signed in to change notification settings - Fork 7.1k
[typscript] change @export to @exports #21754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
thanks! |
@jckr please re-generate the samples (see PR description) |
im debugging the same windows test failure too (unrelated to the samples afaict) the grade |
@macjohnny I have added a commit for the samples |
@jckr can you merge the most recent master? maybe that resolves the CI issues |
FYI this is superseded by #21776 |
closing this in favor of #21776 |
oops, #21776 was for typescript-axios, while this one is for typescript, so reopened and waiting for merging in the latest master branch |
but it raises an interesting question: should the jsdoc be removed altogether, since the information is already present in typescript? |
one of the typescript templates uses a
@export
tag which is incorrect - the right form is@exports
(see https://jsdoc.app/tags-exports). As a result, the generated code may trigger linters.This PR corrects the syntax.
fixes #21753
@TiFu @taxpon @sebastianhaas @kenisteward @Vrolijkx @macjohnny @topce @akehir @petejohansonxo @amakhrov @davidgamero @mkusaka @joscha
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming7.x.0
minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)"fixes #123"
present in the PR description)