Draft
Conversation
…perator_and_operand_from_comparison for removing eval in check() in next commit
so the script doesn't crash on undefined tlm
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3143 +/- ##
==========================================
- Coverage 78.23% 77.58% -0.65%
==========================================
Files 673 471 -202
Lines 55239 34451 -20788
Branches 728 728
==========================================
- Hits 43214 26728 -16486
+ Misses 11947 7645 -4302
Partials 78 78
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
Comment on lines
+13
to
+22
| from openc3.utilities.extract import ( | ||
| add_cmd_parameter, | ||
| extract_fields_from_cmd_text, | ||
| extract_fields_from_tlm_text, | ||
| extract_fields_from_set_tlm_text, | ||
| extract_fields_from_check_text, | ||
| extract_operator_and_operand_from_comparison, | ||
| remove_quotes, | ||
| convert_to_value, | ||
| ) |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a potentially breaking change if users were abusing the
check()API.Before, if you booted fresh COSMOS with the demo and wrote a script with
check(EXAMPLE STATUS VALUE > 1), then the script would crash (even in disconnect mode) because that tlm value is nil/None, which can't be compared using < or >. This fixes that by making sure the eval can be called before calling it and logging an error more gracefully. I also added some other safeguards around the comparisons you can do.Also fixed a couple bugs in extract.py and added unit tests based on the ruby ones.
I gave up removing
eval()because the code paths just became too numerous to keep in my head and I was spending too much time on it; plus like @/ryanmelt mentioned in standup, this is in an executing script anyway. I'd like to remove those, but it's tech debt for another time imo.draft pr because it's late and idk yet if playwright will pass