fix: require Python >= 3.7, add requirements.txt #5
Conversation
Certain features like process.Popen()'s text= kwarg require Python >= 3.7.
|
Our current Dockerfiles for dnf-based builds use python 3.11 and we have instructions for using the prebuilt container rather than messing with python versions on the head node (examples/README.md). Should we also amend our instructions to make the container usage the preferred usage while also adding a guard for python versions that are too old in the code itself? |
|
Container usage can be the preferred way to run image-build and we should be clear in the instructions, but usage should not be limited to the container. For running bare-metal, I think we should have guards (and also instructions) since the code will definitely not run on any Python earlier than 3.7. |
Using `buildah unshare bash -c` requires the user to enclose the image-build command in quotes when running the container, e.g: docker run ghcr.io/openchami/image-build 'image-build --config ...' Removing `bash -c` removes this requirement so that the above command can be ran as: docker run ghcr.io/openchami/image-build image-build --config ... If running multiple commands is needed, you can: docker run ghcr.io/openchami/image-build bash -c 'echo test; image-build --config ...'
|
While testing running the container, I found some peculiarities. For instance, the entire I also noticed that, when running with Docker, I would get: Adding I've pushed commits with these changes and would like to get them reviewed. |
|
We've decided to use Podman as the officially supported way to run the container due to the nature of nested containers. |
Certain features like process.Popen()'s text= kwarg require Python >= 3.7. Add a runtime check for it.
Also, add a
requirements.txtand instructions for using it to install all needed Python dependencies.