Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update build.yaml to handle pull request and tag image tagging #9

Conversation

alexlovelltroy
Copy link
Member

This pull request includes changes to the jobs section in the .github/workflows/build.yaml file to enhance the tagging mechanism for Docker images based on the type of Git reference.

Changes to Docker image tagging:

  • .github/workflows/build.yaml: Modified the tags field to dynamically assign tags based on whether the Git reference is a pull request or a tag. For pull requests, the tag ghcr.io/openchami/image-build:latest-prbuild is used, and for tags, the version-specific tag ghcr.io/openchami/image-build:v<version> is used.

@alexlovelltroy
Copy link
Member Author

Copy link
Contributor

@synackd synackd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@alexlovelltroy alexlovelltroy merged commit dfab763 into main Feb 21, 2025
1 check passed
@alexlovelltroy alexlovelltroy deleted the 8-dev-update-github-workflow-to-prevent-pr-builds-from-being-published-as-latest branch February 21, 2025 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DEV] Update github workflow to prevent PR builds from being published as :latest
2 participants