[microsoft-sentinel-intel] Update connector to be "manager_supported" #5339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Powlinett
added
filigran team
Powlinett
requested review from
Kakudou,
Megafredo,
Ninoxe,
helene-nguyen,
jabesq,
mariot and
throuxel
jabesq
reviewed
Dec 4, 2025
| 4. Default values | ||
| """ | ||
| if Path(settings_cls.model_config["yaml_file"] or "").is_file(): # type: ignore | ||
| if Path(settings_cls.model_config["yaml_file"] or "").is_file(): |
Member
There was a problem hiding this comment.
suggestion
Suggested change
| if Path(settings_cls.model_config["yaml_file"] or "").is_file(): | |
| if Path(settings_cls.model_config.get("yaml_file", "")).is_file(): |
| if Path(settings_cls.model_config["yaml_file"] or "").is_file(): | ||
| return (YamlConfigSettingsSource(settings_cls),) | ||
| if Path(settings_cls.model_config["env_file"] or "").is_file(): # type: ignore | ||
| if Path(settings_cls.model_config["env_file"] or "").is_file(): |
Member
There was a problem hiding this comment.
suggestion
Suggested change
| if Path(settings_cls.model_config["env_file"] or "").is_file(): | |
| if Path(settings_cls.model_config.get("env_file", "")).is_file(): |
Powlinett
force-pushed
the
feat/4847-migrate-microsoft-sentinel-intel
branch
from
64f1d5d to
ac06a00
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
settings.pyconnector.pymain.pyor__main__.pyRelated issues
Checklist
Further comments
The code needs to be reviewed by two people: one must fix any issue, the other one review the final commits.