[Connectors sdk] Create a Reference models #5405
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ninoxe
added
filigran team
5 tasks
Ninoxe
requested review from
Kakudou,
Megafredo,
Powlinett,
helene-nguyen,
jabesq,
mariot and
throuxel
mariot
approved these changes
Dec 15, 2025
Powlinett
reviewed
Dec 15, 2025
| description="The name of the author(s) of this note (e.g., the analyst(s) that created it).", | ||
| ) | ||
| objects: list[BaseIdentifiedEntity] | None = Field( | ||
| objects: list[Union[BaseIdentifiedEntity, Reference]] | None = Field( |
Member
There was a problem hiding this comment.
nit: for consistency purpose, could we use the pipe syntax instead of Union ?
Powlinett
reviewed
Dec 15, 2025
|
|
||
|
|
||
| class Reference(BaseModel): | ||
| """Represent a reference.""" |
Member
There was a problem hiding this comment.
Can you elaborate a bit more the use cases where a Reference should (or shouldn't) be used in the docstring?
Powlinett
reviewed
Dec 15, 2025
Member
Powlinett
left a comment
Powlinett
left a comment
There was a problem hiding this comment.
Thanks @Ninoxe
I notice that it misses the update of the following models:
AssociatedFile(markings)BaseIdentifiedEntity(authorandmarkings)
As the OCTI models fields now accept different types, it would be really nice to update their tests too (one test with a "complete" entity, one test with "just" a Reference) 😇
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Related issues
Checklist