-
Notifications
You must be signed in to change notification settings - Fork 45
Footer Completed #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Footer Completed #42
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@codervipul775, thanks for your work on this PR! A couple of notes for next time:
- There’s no need to add or update
npm packages
unless it’s required for your specific task. Please check with us first if you think a new package is needed. - Before creating a PR, always pull the latest updates from the main branch to avoid conflicts.
- This task was just for the bottom footer, but you also added 'Shipping Policy' and 'Terms of Service' pages, which were not part of your assignment. Please keep PRs focused on the assigned task to help us review and merge changes more efficiently.
Thanks again for your contribution! Let me know if you have any questions.
@codervipul775, delete also |
@Alexandrbig1 , I have deleted package.json and package-lock.json files. |
@codervipul775, thanks, you've deleted |
@Alexandrbig1 , I have deleted package-lock.json file too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to Open Code Chicago! 🎉
Thank you for making your first contribution here — we’re glad to have you. Approved! Great work!
@codervipul775, thanks — there are merge conflicts on your branch. Please resolve them and push an updated branch so I can merge. Leave a comment here when done and I’ll re-review. |
…ct to 18 and regenerate lockfile
@Alexandrbig1 I have resolved the conflicts.The conflicts are for package.json file i.e for required dependencies of react. Now it is working fine. Please review it and merge it |
@codervipul775, thanks — I see the conflicts are resolved. Please remove |
@Alexandrbig1 , I have done the changes(deleted package.json and package.lock.json). Now pls review it and merge it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution, and congrats on your PR being approved!
We’re excited to have your work as part of Open Code Chicago’s Hacktoberfest 2025 project.
@codervipul775, I can’t merge this yet — there are conflicts in |
@codervipul775, please update us on your process. |
@Alexandrbig1 I have completed the #28 Bottom Footer Component . Please review it and merge it . Thankyou for giving me this opportunity.