Skip to content

Conversation

codervipul775
Copy link

@Alexandrbig1 I have completed the #28 Bottom Footer Component . Please review it and merge it . Thankyou for giving me this opportunity.

Copy link
Contributor

@Alexandrbig1 Alexandrbig1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codervipul775, thanks for your work on this PR! A couple of notes for next time:

  • There’s no need to add or update npm packages unless it’s required for your specific task. Please check with us first if you think a new package is needed.
  • Before creating a PR, always pull the latest updates from the main branch to avoid conflicts.
  • This task was just for the bottom footer, but you also added 'Shipping Policy' and 'Terms of Service' pages, which were not part of your assignment. Please keep PRs focused on the assigned task to help us review and merge changes more efficiently.

Thanks again for your contribution! Let me know if you have any questions.

@Alexandrbig1
Copy link
Contributor

@codervipul775, delete also package.json and package-lock.json files from you PR, please.

@codervipul775
Copy link
Author

@Alexandrbig1 , I have deleted package.json and package-lock.json files.

@Alexandrbig1
Copy link
Contributor

@codervipul775, thanks, you've deleted package.json, but package-lock.json is still on PR. Please delete it as well.

@codervipul775
Copy link
Author

@Alexandrbig1 , I have deleted package-lock.json file too.

Copy link
Contributor

@Alexandrbig1 Alexandrbig1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to Open Code Chicago! 🎉
Thank you for making your first contribution here — we’re glad to have you. Approved! Great work!

@Alexandrbig1
Copy link
Contributor

@codervipul775, thanks — there are merge conflicts on your branch. Please resolve them and push an updated branch so I can merge. Leave a comment here when done and I’ll re-review.

@codervipul775
Copy link
Author

@Alexandrbig1 I have resolved the conflicts.The conflicts are for package.json file i.e for required dependencies of react. Now it is working fine. Please review it and merge it

@Alexandrbig1
Copy link
Contributor

@codervipul775, thanks — I see the conflicts are resolved. Please remove package.json and package-lock.json from this PR (we manage dependency changes centrally). I’ve attached a screenshot showing the current PR files — after you remove those files and push the update I’ll re-review and merge.

packa

@codervipul775
Copy link
Author

@Alexandrbig1 , I have done the changes(deleted package.json and package.lock.json). Now pls review it and merge it.

Copy link
Contributor

@Alexandrbig1 Alexandrbig1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution, and congrats on your PR being approved!
We’re excited to have your work as part of Open Code Chicago’s Hacktoberfest 2025 project.

@Alexandrbig1 Alexandrbig1 added hacktoberfest Special issue for Hacktoberfest hacktoberfest-2025 Special issue for Hacktoberfest 2025 hacktoberfest-accepted This label indicates that a contribution has been accepted and counts toward Hacktoberfest rewards. react React components & UI logic tailwind Tailwind CSS & styling labels Oct 7, 2025
@Alexandrbig1
Copy link
Contributor

@codervipul775, I can’t merge this yet — there are conflicts in package-lock.json and CI is failing. Please pull the latest main, resolve the conflicts, push the updated branch, and I’ll re-review. Thanks!
ci

@Alexandrbig1 Alexandrbig1 added this to the Hacktoberfest 2025 milestone Oct 8, 2025
@Alexandrbig1
Copy link
Contributor

@codervipul775, please update us on your process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest Special issue for Hacktoberfest hacktoberfest-2025 Special issue for Hacktoberfest 2025 hacktoberfest-accepted This label indicates that a contribution has been accepted and counts toward Hacktoberfest rewards. react React components & UI logic tailwind Tailwind CSS & styling
Development

Successfully merging this pull request may close these issues.

2 participants