-
Notifications
You must be signed in to change notification settings - Fork 66
updated/#11 - top header #91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated/#11 - top header #91
Conversation
a8f7224
to
b2fa689
Compare
@anasfarock, may you exclude |
@Alexandrbig1 since, react-icons/fa are being used instead of lucide-icons to resolve the depreciated icons issue. should I replace back these icons with lucide-icons? |
@anasfarock, keep react-icons/fa — it’s fine to fix the deprecation. Only switch back to lucide-icons if you need lucide-specific features or consistency across the app; otherwise leave it as is. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution, and congrats on your PR being approved!
We’re excited to have your work as part of Open Code Chicago’s Hacktoberfest 2025 project.
Pull Request
Description
#56 updated z-index in top header to fix the overlapping issue. adjusted paddings in the main header to have more space for top header (px-8 -> px-9), replaced depreciated lucide-icons in the top header with react-icons.
Checklist