Skip to content

Conversation

anasfarock
Copy link
Contributor

Pull Request

Description

#56 updated z-index in top header to fix the overlapping issue. adjusted paddings in the main header to have more space for top header (px-8 -> px-9), replaced depreciated lucide-icons in the top header with react-icons.

Checklist

  • My code builds and runs locally
  • I’ve added/updated documentation if needed
  • I’ve tested my changes
  • I’ve linked related issues (if any)
  • (Optional) I’ve credited myself with the All Contributors bot if this is my first contribution or a new contribution type

@anasfarock anasfarock force-pushed the feat/#11-top-header branch from a8f7224 to b2fa689 Compare October 9, 2025 08:13
@Alexandrbig1
Copy link
Contributor

@anasfarock, may you exclude package.json and package-lock.json files from the PR, please.
del

@rmbarley rmbarley mentioned this pull request Oct 9, 2025
5 tasks
@anasfarock
Copy link
Contributor Author

@Alexandrbig1 since, react-icons/fa are being used instead of lucide-icons to resolve the depreciated icons issue. should I replace back these icons with lucide-icons?

@Alexandrbig1
Copy link
Contributor

@anasfarock, keep react-icons/fa — it’s fine to fix the deprecation. Only switch back to lucide-icons if you need lucide-specific features or consistency across the app; otherwise leave it as is.

Copy link
Contributor

@Alexandrbig1 Alexandrbig1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution, and congrats on your PR being approved!
We’re excited to have your work as part of Open Code Chicago’s Hacktoberfest 2025 project.

@Alexandrbig1 Alexandrbig1 added frontend Tasks related to the frontend (React, Vite, TailwindCSS, UI components, pages) hacktoberfest Special issue for Hacktoberfest hacktoberfest-2025 Special issue for Hacktoberfest 2025 hacktoberfest-accepted This label indicates that a contribution has been accepted and counts toward Hacktoberfest rewards. react React components & UI logic tailwind Tailwind CSS & styling labels Oct 12, 2025
@Alexandrbig1 Alexandrbig1 added this to the Hacktoberfest 2025 milestone Oct 12, 2025
@Alexandrbig1 Alexandrbig1 merged commit bb8bd1d into OpenCodeChicago:main Oct 12, 2025
2 checks passed
@Alexandrbig1 Alexandrbig1 linked an issue Oct 12, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend Tasks related to the frontend (React, Vite, TailwindCSS, UI components, pages) hacktoberfest Special issue for Hacktoberfest hacktoberfest-2025 Special issue for Hacktoberfest 2025 hacktoberfest-accepted This label indicates that a contribution has been accepted and counts toward Hacktoberfest rewards. react React components & UI logic tailwind Tailwind CSS & styling

Development

Successfully merging this pull request may close these issues.

Top Header

2 participants