Skip to content

Add input validation for Activation Code and Document Number #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add input validation for Activation Code and Document Number #310

wants to merge 1 commit into from

Conversation

tvdijen
Copy link
Contributor

@tvdijen tvdijen commented Jan 4, 2024 •
edited
Loading

This PR:

  • Restricts document numbers to 6 characters, being A-Z, 0-9 or a hyphen
  • Restricts activation codes to 8 characters, being A-Z or 0-9

Debatable:

  • This makes the input of a document number mandatory to be able to send the form. A single - is accepted in case a document number isn't of any interest to the RA(A).

Related: OpenConext/Stepup-Middleware#415

@tvdijen tvdijen mentioned this pull request Jan 4, 2024
Open
@tvdijen tvdijen requested a review from MKodde January 4, 2024 20:44
@MKodde MKodde deleted the branch OpenConext:develop May 15, 2024 10:22
@MKodde MKodde closed this May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MKodde MKodde Awaiting requested review from MKodde

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tvdijen @MKodde