feat: added a 404 page so users don’t get too lost and can escape the… #558
Conversation
… dreaded 404 abyss
|
@megh-bari is attempting to deploy a commit to the OpenCut OSS Team on Vercel. A member of the Team first needs to authorize it. |
👷 Deploy request for appcut pending review.Visit the deploys page to approve it
|
WalkthroughAdds a Next.js App Router NotFound page at Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant NextAppRouter as Next.js App Router
participant NotFound as not-found.tsx
participant Home as "/"
User->>NextAppRouter: Request unknown route
NextAppRouter->>NotFound: Render NotFound page
NotFound-->>User: Display 404 view with image and button
User->>NotFound: Click "Go Back To Home"
NotFound->>Home: Navigate to "/"
Home-->>User: Render homepage
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. 📜 Recent review detailsConfiguration used: CodeRabbit UI 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
apps/web/src/app/not-found.tsx (2)
6-10:metadataexport is likely ignored innot-found.tsxIn Next.js App Router,
metadata/generateMetadataare supported onpage.tsxandlayout.tsx, notnot-found.tsx. This export may be a no-op and could confuse future maintainers. Consider removing it or moving the title/description logic to the nearest layout/page.Apply:
-export const metadata = { - title: "404 | Page Not Found - OpenCut", - description: - "Oops! The page you’re looking for isn’t available. Head back to the homepage or continue exploring OpenCut.", -};If you want a 404-specific title, we can explore a layout-level title template approach or centralize metadata in
app/layout.tsx.
, add an H1, and fix extra whitespace
14-16: Minor a11y/semantics polish: use
- Prefer a semantic
<main>landmark for primary content.- Provide a visible
<h1>(“Page not found”) to set page context for screen readers.- Remove the double space in
text-gray-600 mb-8.- <div className="min-h-screen flex bg-white items-center justify-center"> + <main className="min-h-screen flex bg-white items-center justify-center" role="main"> <div className="text-center"> <div className="mb-4"> @@ - <p className="text-gray-600 mb-8"> + <h1 className="text-2xl font-semibold mb-2">Page not found</h1> + <p className="text-gray-600 mb-8"> Sorry, the page you're looking for can't be found. </p> @@ - </div> + </main>Also applies to: 25-27, 35-35
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
apps/web/public/images/404-custom.pngis excluded by!**/*.png
📒 Files selected for processing (1)
apps/web/src/app/not-found.tsx(1 hunks)
🧰 Additional context used
📓 Path-based instructions (5)
**/*.{jsx,tsx}
📄 CodeRabbit Inference Engine (.github/copilot-instructions.md)
**/*.{jsx,tsx}: Don't useaccessKeyattribute on any HTML element.
Don't setaria-hidden="true"on focusable elements.
Don't add ARIA roles, states, and properties to elements that don't support them.
Don't use distracting elements like<marquee>or<blink>.
Only use thescopeprop on<th>elements.
Don't assign non-interactive ARIA roles to interactive HTML elements.
Make sure label elements have text content and are associated with an input.
Don't assign interactive ARIA roles to non-interactive HTML elements.
Don't assigntabIndexto non-interactive HTML elements.
Don't use positive integers fortabIndexproperty.
Don't include "image", "picture", or "photo" in img alt prop.
Don't use explicit role property that's the same as the implicit/default role.
Make static elements with click handlers use a valid role attribute.
Always include atitleelement for SVG elements.
Give all elements requiring alt text meaningful information for screen readers.
Make sure anchors have content that's accessible to screen readers.
AssigntabIndexto non-interactive HTML elements witharia-activedescendant.
Include all required ARIA attributes for elements with ARIA roles.
Make sure ARIA properties are valid for the element's supported roles.
Always include atypeattribute for button elements.
Make elements with interactive roles and handlers focusable.
Give heading elements content that's accessible to screen readers (not hidden witharia-hidden).
Always include alangattribute on the html element.
Always include atitleattribute for iframe elements.
AccompanyonClickwith at least one of:onKeyUp,onKeyDown, oronKeyPress.
AccompanyonMouseOver/onMouseOutwithonFocus/onBlur.
Include caption tracks for audio and video elements.
Use semantic elements instead of role attributes in JSX.
Make sure all anchors are valid and navigable.
Ensure all ARIA properties (aria-*) are valid.
Use valid, non-abstract ARIA roles for elements with...
Files:
apps/web/src/app/not-found.tsx
**/*.{ts,tsx}
📄 CodeRabbit Inference Engine (.github/copilot-instructions.md)
**/*.{ts,tsx}: Don't use TypeScript enums.
Don't export imported variables.
Don't add type annotations to variables, parameters, and class properties that are initialized with literal expressions.
Don't use TypeScript namespaces.
Don't use non-null assertions with the!postfix operator.
Don't use parameter properties in class constructors.
Don't use user-defined types.
Useas constinstead of literal types and type annotations.
Use eitherT[]orArray<T>consistently.
Initialize each enum member value explicitly.
Useexport typefor types.
Useimport typefor types.
Make sure all enum members are literal values.
Don't use TypeScript const enum.
Don't declare empty interfaces.
Don't let variables evolve into any type through reassignments.
Don't use the any type.
Don't misuse the non-null assertion operator (!) in TypeScript files.
Don't use implicit any type on variable declarations.
Don't merge interfaces and classes unsafely.
Don't use overload signatures that aren't next to each other.
Use the namespace keyword instead of the module keyword to declare TypeScript namespaces.
Don't use empty type parameters in type aliases and interfaces.
Don't use any or unknown as type constraints.
Don't use the TypeScript directive @ts-ignore.
Use consistent accessibility modifiers on class properties and methods.
Use function types instead of object types with call signatures.
Don't use void type outside of generic or return types.
**/*.{ts,tsx}: Don't use primitive type aliases or misleading types
Don't use the TypeScript directive @ts-ignore
Don't use TypeScript enums
Use either T[] or Array consistently
Don't use the any type
Files:
apps/web/src/app/not-found.tsx
**/*.{js,jsx,ts,tsx}
📄 CodeRabbit Inference Engine (.github/copilot-instructions.md)
**/*.{js,jsx,ts,tsx}: Don't use the return value of React.render.
Don't use consecutive spaces in regular expression literals.
Don't use theargumentsobject.
Don't use primitive type aliases or misleading types.
Don't use the comma operator.
Don't write functions that exceed a given Cognitive Complexity score.
Don't use unnecessary boolean casts.
Don't use unnecessary callbacks with flatMap.
Use for...of statements instead of Array.forEach.
Don't create classes that only have static members (like a static namespace).
Don't use this and super in static contexts.
Don't use unnecessary catch clauses.
Don't use unnecessary constructors.
Don't use unnecessary continue statements.
Don't export empty modules that don't change anything.
Don't use unnecessary escape sequences in regular expression literals.
Don't use unnecessary labels.
Don't use unnecessary nested block statements.
Don't rename imports, exports, and destructured assignments to the same name.
Don't use unnecessary string or template literal concatenation.
Don't use String.raw in template literals when there are no escape sequences.
Don't use useless case statements in switch statements.
Don't use ternary operators when simpler alternatives exist.
Don't use uselessthisaliasing.
Don't initialize variables to undefined.
Don't use the void operators (they're not familiar).
Use arrow functions instead of function expressions.
Use Date.now() to get milliseconds since the Unix Epoch.
Use .flatMap() instead of map().flat() when possible.
Use literal property access instead of computed property access.
Don't use parseInt() or Number.parseInt() when binary, octal, or hexadecimal literals work.
Use concise optional chaining instead of chained logical expressions.
Use regular expression literals instead of the RegExp constructor when possible.
Don't use number literal object member names that aren't base 10 or use underscore separators.
Remove redundant terms from logical expressions.
Use while loops instead of...
Files:
apps/web/src/app/not-found.tsx
**/*.{tsx,jsx}
📄 CodeRabbit Inference Engine (.cursor/rules/ultracite.mdc)
**/*.{tsx,jsx}: Always include a title element for icons unless there's text beside the icon
Always include a type attribute for button elements
Accompany onClick with at least one of: onKeyUp, onKeyDown, or onKeyPress
Accompany onMouseOver/onMouseOut with onFocus/onBlur
Don't import React itself
Don't define React components inside other components
Don't use both children and dangerouslySetInnerHTML on the same element
Don't insert comments as text nodes
Use <>...</> instead of ...
Files:
apps/web/src/app/not-found.tsx
**/*.{ts,tsx,js,jsx}
📄 CodeRabbit Inference Engine (.cursor/rules/ultracite.mdc)
**/*.{ts,tsx,js,jsx}: Don't use the comma operator
Use for...of statements instead of Array.forEach
Don't initialize variables to undefined
Use .flatMap() instead of map().flat() when possible
Don't assign a value to itself
Avoid unused imports and variables
Don't use await inside loops
Don't hardcode sensitive data like API keys and tokens
Don't use the delete operator
Don't use global eval()
Use String.slice() instead of String.substr() and String.substring()
Don't use else blocks when the if block breaks early
Put default function parameters and optional function parameters last
Use new when throwing an error
Use String.trimStart() and String.trimEnd() over String.trimLeft() and String.trimRight()
Files:
apps/web/src/app/not-found.tsx
🧠 Learnings (1)
📓 Common learnings
Learnt from: CR
PR: OpenCut-app/OpenCut#0
File: .cursor/rules/ultracite.mdc:0-0
Timestamp: 2025-08-15T00:50:09.126Z
Learning: Applies to {pages/**/**/*.{tsx,jsx},app/**/**/*.{tsx,jsx},src/pages/**/**/*.{tsx,jsx},src/app/**/**/*.{tsx,jsx}} : Don't use <img> elements in Next.js projects
Learnt from: CR
PR: OpenCut-app/OpenCut#0
File: .cursor/rules/ultracite.mdc:0-0
Timestamp: 2025-08-15T00:50:09.126Z
Learning: Applies to {pages/**/**/*.{tsx,jsx},app/**/**/*.{tsx,jsx},src/pages/**/**/*.{tsx,jsx},src/app/**/**/*.{tsx,jsx}} : Don't use <head> elements in Next.js projects
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Vade Review
🔇 Additional comments (1)
apps/web/src/app/not-found.tsx (1)
17-23: Good use of Next/Image and alt text
- Uses
next/image(aligned with our “noin Next.js” guideline).
- Alt text is concise and meaningful.
|
I'm confused about line 9 in not-found.tsx, what do you mean by "or continue exploring OpenCut"? |
Just add it casually, nothing else. It means both "Go to Home Page" and " Continue Explore OpenCut" take you to the homepage, where you can explore. It’s just a description for metadata bruh |
2 participants
… dreaded 404 abyss
Description
This PR implements a custom 404 (Page Not Found) page with a “Go Back To Home” button to replace the default Next.js error page. The new page provides a branded user experience that aligns with OpenCut's design system and offers clear navigation back to the main application. it help users easily return to the homepage when they hit a missing page.
Previously, users encountering non-existent routes would see a generic browser/Next.js error page. This custom implementation maintains brand consistency and provides a better user experience with helpful navigation options.
Screenshots
Laptop View
Mobile View
Type of change
How Has This Been Tested?
Test Configuration:
Test Steps:
bun devhttp://localhost:3000/non-existent-pageChecklist:
Additional context
This update improves user experience by guiding users from dead-end pages back to the homepage quickly.
Design Decisions:
not-found.tsxfor automatic 404 handlingFiles Added:
src/app/not-found.tsx- Custom 404 page componentpublic/images/404-custom.png- Branded 404 image assetThis contribution aligns with the project's contribution guidelines, focusing on UI/UX improvements while avoiding the preview system area scheduled for refactoring.
Summary by CodeRabbit