Skip to content

Conversation

@whoTBecker
Copy link
Contributor

Abort sdo download request if size exceeds allowed length.
Only accept ca download if size matches.
Fix complete access of bit data types.
Allow ca access for objects with flexible length.
Correct validation of sdo segmented request.
Serve correct datatype for SDO get object description.
Correct size limit for complete access.

(Also included: Pull-Request #194 and #197 )

whoTBecker and others added 19 commits March 4, 2025 11:34
check maximum allowed length of service data for incoming mailbox
validate minimum required mailbox size
Set cnt value just before a mailbox message is sent.
Adjust bitfield for cnt value within mailbox header structure.
* fix: correct abort code for not supported complete access

* add description for complete_access_subindex_loop() and remove redundant parameter
Consider possible change of number of subindexes of type array for ca download
Affected to previous bugfix 'allow ca access for objects with flexible length'.
Add validation of toggle bit for sdo segmented upload and download
During iteration of an object, non-existent subindices have to be considered.
@whoTBecker whoTBecker changed the title fix: sdo service fix: Sdo service May 9, 2025
@whoTBecker whoTBecker changed the title fix: Sdo service fix: SDO service May 9, 2025
@nakarlsson
Copy link
Contributor

nakarlsson commented May 22, 2025

Can you guys please squash functional commits + fixes tied to functional commits? Would make life easier for us to review.
Otherwise we need double check possible issues with later commits that might include fixes.

thanks

@CLAassistant
Copy link

CLAassistant commented Sep 23, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 3 committers have signed the CLA.

❌ ule29147
❌ whoTBecker
❌ whoMBadura
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants