-
Notifications
You must be signed in to change notification settings - Fork 305
fix: SDO service #198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix: SDO service #198
Conversation
check maximum allowed length of service data for incoming mailbox validate minimum required mailbox size
Set cnt value just before a mailbox message is sent. Adjust bitfield for cnt value within mailbox header structure.
* fix: correct abort code for not supported complete access * add description for complete_access_subindex_loop() and remove redundant parameter
Consider possible change of number of subindexes of type array for ca download
Affected to previous bugfix 'allow ca access for objects with flexible length'.
Add validation of toggle bit for sdo segmented upload and download
During iteration of an object, non-existent subindices have to be considered.
|
Can you guys please squash functional commits + fixes tied to functional commits? Would make life easier for us to review. thanks |
|
|
Abort sdo download request if size exceeds allowed length.
Only accept ca download if size matches.
Fix complete access of bit data types.
Allow ca access for objects with flexible length.
Correct validation of sdo segmented request.
Serve correct datatype for SDO get object description.
Correct size limit for complete access.
(Also included: Pull-Request #194 and #197 )