Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP: don't review] New storage in network planner CLI #470

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

dwhswenson
Copy link
Member

This will add a flag to use our new storage to output an alchemical network in the CLI network planners. For now, this option is hidden (doesn't show in --help), so we have full freedom to change the UX later. That way we can dogfood new storage with actual release code.

As of pushing the PR, nothing is actually hooked into storage. Just giving a heads-up that I'll be working on it.

@dwhswenson dwhswenson changed the title Start new storage in network planner CLI [WIP: don't review] New storage in network planner CLI Jun 22, 2023
@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Attention: Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.

Project coverage is 91.61%. Comparing base (e62b214) to head (abed241).
Report is 1344 commits behind head on main.

Files with missing lines Patch % Lines
openfecli/commands/plan_rbfe_network.py 66.66% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #470      +/-   ##
==========================================
- Coverage   91.64%   91.61%   -0.04%     
==========================================
  Files         110      110              
  Lines        6549     6557       +8     
==========================================
+ Hits         6002     6007       +5     
- Misses        547      550       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@atravitz atravitz added the cli command-line interface label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli command-line interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants