-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cli protocol settings via yaml input #770
base: main
Are you sure you want to change the base?
Conversation
Hello @richardjgowers! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2024-03-11 15:27:24 UTC |
a63fd83
to
057d0c4
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #770 +/- ##
==========================================
- Coverage 93.57% 91.84% -1.73%
==========================================
Files 133 133
Lines 9748 9839 +91
==========================================
- Hits 9122 9037 -85
- Misses 626 802 +176
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
can create a Protocol instance from settings yaml now
previously would warn about duplicates when not necessary
didn't render nicely via command line --help, so instead put the example code into the userguide docs
4987302
to
8df0b05
Compare
Checklist
news
entryDevelopers certificate of origin