Report compilation errors in exception#142
Open
Marcono1234 wants to merge 2 commits intoOpenHFT:eafrom
Open
Conversation
Marcono1234
commented
Jul 21, 2024
Comment on lines
+420
to
+431
| public void test_compilerErrorsButLoadingDifferentClass() throws Exception { | ||
| // quieten the compiler output | ||
| PrintWriter quietWriter = new PrintWriter(new StringWriter()); | ||
|
|
||
| // TODO: Should this throw an exception due to the compilation error nonetheless to be less | ||
| // error-prone for users, even if loading class would succeed? | ||
| Class<?> testClass = compiler.loadFromJava(classLoader, | ||
| // Load other class which is unaffected by compilation error | ||
| String.class.getName(), | ||
| "clazz X {}", quietWriter); | ||
| assertSame(String.class, testClass); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Open question: This mirrors the existing behavior, but personally I think it would be cleaner to always have CachedCompiler throw an exception (ClassNotFoundException?) when compilation errors occur. Even if loading the class would succeed in the end, because that class was unaffected by the compilation errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is based on #141 for simplicity; but if you want I can try to base it on the
eabranch instead.Relates to #35
Currently when you call
CachedCompiler#loadFromJavawith code containing compilation errors, you just get aClassNotFoundExceptionwithout any details. And depending on whether you used a customPrinterWriteryou then either have to inspect its output orSystem.errconsole output to understand the actual case.This can be rather confusing and makes troubleshooting more difficult.
This pull request here collects Error diagnostics and in case of a
ClassNotFoundExceptionincludes those in the exception message.