Skip to content

Fix Browser action deserialization by using OpenHandsModel #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
simonrosenberg wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Fix Browser action deserialization by using OpenHandsModel #136

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion benchmarks/utils/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
from openhands.sdk import LLM, Event, get_logger
from openhands.sdk.critic import CriticBase
from openhands.sdk.llm import Metrics
from openhands.sdk.utils.models import OpenHandsModel


logger = get_logger(__name__)
Expand Down Expand Up @@ -68,7 +69,22 @@ class EvalInstance(BaseModel):
)


class EvalOutput(BaseModel):
class EvalOutput(OpenHandsModel):
"""
Evaluation output model.

Uses OpenHandsModel instead of BaseModel to ensure pydantic schemas are properly
rebuilt when new discriminated union types (like Browser actions/observations)
are dynamically registered at runtime.

Without this, pydantic caches the Event discriminated union schema at import time,
before Browser tools are registered. When deserializing output.jsonl files that
contain Browser events, pydantic fails with "Unexpected kind BrowserGetContentAction"
because the schema doesn't include the newly registered types.

OpenHandsModel automatically calls model_rebuild() before validation, regenerating
the schema to include all registered event types.
"""
# NOTE: User-specified
instance_id: str
# output of the evaluation
Expand Down
Loading