Upstream #3
Open
Upstream #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The paginator widget in the changeset list sidebar had an odd behavior where the prev/next arrows did not work after initial page load, and would only start working once you clicked on a specific page number (e.g '2'). Turns out this is because of some sneaky square brackets in one of the Redux selectors which caused pageIndex to be accidentally converted into an array `[0]`. The expression `[0] + 1` evaluates to the string `"01"` in JavaScript (of course it does), resulting in the frontend trying to fetch page `01`, then `011`, then `0111`, etc on each subsequent click of the next button, none of which would succeed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.