Sentry errors #606
Sentry errors #606
Conversation
…86f4f2288baec1c541ce36d)
…beddb0406ba50ffa2a56a27f66)
Deploying with
|
| Latest commit: |
3419074
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://36aabb9c.miqa.pages.dev |
| Branch Preview URL: | https://sentry-errors.miqa.pages.dev |
| currentViewData?.scanDecisions === undefined | ||
| || currentViewData?.scanDecisions?.length === 0 |
There was a problem hiding this comment.
| currentViewData?.scanDecisions === undefined | |
| || currentViewData?.scanDecisions?.length === 0 | |
| !currentViewData?.scanDecisions?.length |
Is this equivalent?
There was a problem hiding this comment.
Yes, thanks for the short version!
There was a problem hiding this comment.
Actually, I'm discovering that neither works; we cannot use the ? operator like this within the template. vuejs/vue#11088.
There was a problem hiding this comment.
If we did want to use that syntax, we could throw it into a computed property and use that in the template.
Codecov ReportBase: 72.77% // Head: 72.77% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #606 +/- ##
=======================================
Coverage 72.77% 72.77%
=======================================
Files 38 38
Lines 1627 1627
=======================================
Hits 1184 1184
Misses 443 443 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
LGTM. I think moving a lot of this to typescript would catch a lot of these errors at build time. |
* Enforce consistent api response destructuring (Sentry error dfc24eeb686f4f2288baec1c541ce36d) * Avoid sending requests with undefined references (Sentry error 873d87beddb0406ba50ffa2a56a27f66) * Avoid accessing properties of undefined objects (various Sentry errors) * No optional chaining in template
No description provided.