chore: increase log level for daemon _serve args to info #169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joel-wong-aws
force-pushed
the
log_daemon_command
branch
from
fbed152 to
eaf7077
Compare
|
Signed-off-by: Joel Wong <[email protected]>
joel-wong-aws
force-pushed
the
log_daemon_command
branch
from
eaf7077 to
5087f4e
Compare
|
baxeaz
approved these changes
Jan 31, 2025
crowecawcaw
approved these changes
Jan 31, 2025
jblagden
pushed a commit
to jblagden/openjd-adaptor-runtime-for-python
that referenced
this pull request
Aug 21, 2025
…ription#169) Signed-off-by: Joel Wong <[email protected]> Signed-off-by: Justin Blagden <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
As I was debugging an issue with starting an adaptor, I got the error message
It's difficult to understand what went wrong here because the error message does not contain the command that was attempted to be run.
What was the solution? (How)
Increased log level from debug to info when printing out the arrgs that are about to be run before this command.
What is the impact of this change?
This will make it easier to debug issues when adaptors fail to start.
How was this change tested?
Added a unit test for the logs being printed at INFO level, it passed.
Yes
Was this change documented?
No, N/A
Is this a breaking change?
No
Does this change impact security?
No
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.