Skip to content

Conversation

@mwiebe
Copy link
Contributor

@mwiebe mwiebe commented Apr 8, 2025

What was the problem/requirement? (What/Why)

See OpenJobDescription/openjd-adaptor-runtime-for-python#162. openjd-sessions is a library and will be more compatible with clients using it with fewer restrictions on dependencies.

What was the solution? (How)

Update the pywin32 dependency to be '>= 307'. This matches the choice in OpenJobDescription/openjd-adaptor-runtime-for-python#162.

What is the impact of this change?

Will be able to install the library in more contexts.

How was this change tested?

Ran unit tests.

Was this change documented?

N/A

Is this a breaking change?

No

Does this change impact security?

  • Does the change need to be threat modeled? For example, does it create or modify files/directories that must only be readable by the process owner?
    • If so, then please label this pull request with the "security" label. We'll work with you to analyze the threats.
      No

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@mwiebe mwiebe requested a review from a team as a code owner April 8, 2025 17:33
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 8, 2025

@mwiebe mwiebe enabled auto-merge (rebase) April 8, 2025 17:36
@mwiebe mwiebe merged commit a1707f7 into OpenJobDescription:mainline Apr 8, 2025
19 checks passed
@mwiebe mwiebe deleted the pywin32-dep branch April 8, 2025 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants