test: add timestamp for captured logging #293
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.



What was the problem/requirement? (What/Why)
Trying to debug some time-senstive tests and why they're failing, but unable to determine when information is being logged without adding it to the message.
What was the solution? (How)
Change the pytest log format
What is the impact of this change?
Here's a time sensitive test that was failing since "Log from test 4" was not in the log messages. before the change, we can't tell why the action that prints every second didn't print the last log message.
Before
After
With the new logging, we can see that it's taking longer than 1 second from
Output:to the first log we receive. We're asserting thattimeout - 1appears in the logs, which will fail if it takes longer than 1 second to start printing.How was this change tested?
Was this change documented?
N/A
Is this a breaking change?
N/A
Does this change impact security?
N/A
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.