variable resolution- allow empty values (#348)

* vaiable resolution- allow empty values Signed-off-by: Arun Venmany <[email protected]> * rolled back workflow yaml changes Signed-off-by: Arun Venmany <[email protected]> --------- Signed-off-by: Arun Venmany <[email protected]>
OpenLiberty · Feb 28, 2025 · 8869e8e · 8869e8e
1 parent d3c5dbe
commit 8869e8e
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/lemminx-liberty/src/it/variable-processing-ol-it/src/test/java/LibertyWorkspaceIT.java b/lemminx-liberty/src/it/variable-processing-ol-it/src/test/java/LibertyWorkspaceIT.java
@@ -218,7 +218,7 @@ public void testInvalidVariableDiagnosticWithCodeAction() throws IOException, Ba
                     .setUri(serverXmlFile.toURI().toString());
         }
         texted = te(7, 0,
-                7, 0, String.format("    <variable name=\"%s\" value=\" \"/> %s","default.https",System.lineSeparator()));
+                7, 0, String.format("    <variable name=\"%s\" value=\"\"/> %s","default.https",System.lineSeparator()));
         invalidCodeAction = ca(invalid1, texted);
         invalidCodeAction.getEdit()
                 .getDocumentChanges()

diff --git a/...ty/src/main/java/io/openliberty/tools/langserver/lemminx/codeactions/ReplaceVariable.java b/...ty/src/main/java/io/openliberty/tools/langserver/lemminx/codeactions/ReplaceVariable.java
@@ -72,7 +72,7 @@ public void doCodeAction(ICodeActionRequest request, List<CodeAction> codeAction
                 // line separator in end of text insert will move current diagnostic line to 1 line
                 insertPos.setLine(diagnostic.getRange().getEnd().getLine());
                 codeActions.add(CodeActionFactory.insert("Add variable " + invalidVariable, insertPos,
-                        String.format("    <variable name=\"%s\" value=\" \"/> %s", invalidVariable, System.lineSeparator()),
+                        String.format("    <variable name=\"%s\" value=\"\"/> %s", invalidVariable, System.lineSeparator()),
                         document.getTextDocument(), diagnostic));
             }
         } catch (Exception e) {

diff --git a/lemminx-liberty/src/test/java/io/openliberty/LibertyDiagnosticTest.java b/lemminx-liberty/src/test/java/io/openliberty/LibertyDiagnosticTest.java
@@ -974,7 +974,7 @@ public void testInvalidVariableDiagnosticWithCodeAction() throws BadLocationExce
                     .setUri(serverXMLURI);
         }
         texted = te(7, 0,
-                7, 0, String.format("    <variable name=\"%s\" value=\" \"/> %s","default.https",System.lineSeparator()));
+                7, 0, String.format("    <variable name=\"%s\" value=\"\"/> %s","default.https",System.lineSeparator()));
         invalidCodeAction = ca(invalid1, texted);
         invalidCodeAction.getEdit()
                 .getDocumentChanges()