Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature completion fix #315

Merged
merged 4 commits into from
Oct 22, 2024
Merged

Feature completion fix #315

merged 4 commits into from
Oct 22, 2024

Conversation

arunvenmany-ibm
Copy link
Contributor

@arunvenmany-ibm arunvenmany-ibm commented Oct 22, 2024 •
edited
Loading

Fix for OpenLiberty/liberty-tools-intellij#1035

Issue identified due to 2 things

  1. when same featurename is added multiple times, its not getting added to existing features since code consider both are current line feature
  2. In code LibertyCompletionParticpant#buildCompletionItems(), previous code was not striping full version field, it was keeping "-" . when we changed to LibertyUtils.stripVersion, hyphen got removed. resolving that issue

@cherylking cherylking merged commit d79adf1 into OpenLiberty:main Oct 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cherylking cherylking cherylking approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arunvenmany-ibm @cherylking