Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi value property fix #343

Merged

Conversation

arunvenmany-ibm
Copy link
Contributor

fixes #336

@arunvenmany-ibm
Copy link
Contributor Author

arunvenmany-ibm commented Feb 4, 2025

writing down newly developed behaviors below for multi values variables

  1. Completion
  • When user trigger completion with single value, behavior is similar to any other single value field
    image
  • When user enters a comma after first value and do a completion, all the allowed
    image
  • When user add more values and trigger completion, result will show all available completions, excluding already selected
    image
  • If user enters an invalid value anywhere in the string and try completion, no completion will be show
    image
    image
  1. Diagnostics
  • When user does not enter any value or just enter comma or just ends with comma, diagnostics will be shown
    image
    image

  • When user enters an invalid value anywhere in the multi value string, a diagnostics will be shown. Here an additional comma is added
    image

  • When user enters invalid values in between the valid values, diagnostic message will contain only error value
    image

  1. Code Action(QuickFix)
  • When user enter only one invalid value or multiple invalid values, quickfix will show option to replace with a single property
    image
  • When user enters some valid values and some invalid values, quickfix will show option to replace with all correct values in existing string or option to select all correct values plus one additional valid value
    Here you can see already 3 values are correct in user entered string, in quickfix all three correct values are shown as a replace option
    Furthermore replace options are available with already selected valid values plus additional allowed values
    image

Copy link
Member

@cherylking cherylking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love all the new method documentation.

@arunvenmany-ibm arunvenmany-ibm merged commit 050c719 into OpenLiberty:main Feb 10, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

server.env validation reports error on multiple console source
2 participants