Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

variable resolution, changes based on demo #346

Merged

Conversation

arunvenmany-ibm
Copy link
Contributor

as suggested in the call, variable completion will show up only when user enters ${

Copy link
Member

@cherylking cherylking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one question

@cherylking
Copy link
Member

Will you have a separate PR for the other feedback from the demo regarding showing the predefined Liberty variables like server.config.dir?

@arunvenmany-ibm
Copy link
Contributor Author

Will you have a separate PR for the other feedback from the demo regarding showing the predefined Liberty variables like server.config.dir?

Yes.. It need changes in ci.common
Or we can keep this PR and make ci.common changes, and integrate those and add variable-processing test
Can you list down the properties we need to add ?

@cherylking
Copy link
Member

Yes.. It need changes in ci.common

Do we display a value for the predefined variables for hover? What change are you needing to add to ci.common?

I think we could maintain a list of the predefined variables in LCLS. They won't be changing often (if ever). You can find the list in the second column here.

@arunvenmany-ibm
Copy link
Contributor Author

Yes.. It need changes in ci.common

Do we display a value for the predefined variables for hover? What change are you needing to add to ci.common?

I think we could maintain a list of the predefined variables in LCLS. They won't be changing often (if ever). You can find the list in the second column here.

We need to add these default variables into list of variables while variables are processed in ServerConfigDocument
I think we should manage it in ci.common itself

Signed-off-by: Arun Venmany <[email protected]>
Signed-off-by: Arun Venmany <[email protected]>
Signed-off-by: Arun Venmany <[email protected]>
@arunvenmany-ibm arunvenmany-ibm merged commit 349a02c into OpenLiberty:main Feb 14, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants