-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
variable resolution, changes based on demo #346
variable resolution, changes based on demo #346
Conversation
Signed-off-by: Arun Venmany <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the one question
...erty/src/main/java/io/openliberty/tools/langserver/lemminx/LibertyCompletionParticipant.java
Show resolved
Hide resolved
Will you have a separate PR for the other feedback from the demo regarding showing the predefined Liberty variables like |
Yes.. It need changes in ci.common |
Do we display a value for the predefined variables for hover? What change are you needing to add to ci.common? I think we could maintain a list of the predefined variables in LCLS. They won't be changing often (if ever). You can find the list in the second column here. |
We need to add these default variables into list of variables while variables are processed in ServerConfigDocument |
Signed-off-by: Arun Venmany <[email protected]>
Signed-off-by: Arun Venmany <[email protected]>
Signed-off-by: Arun Venmany <[email protected]>
Signed-off-by: Arun Venmany <[email protected]>
Signed-off-by: Arun Venmany <[email protected]>
as suggested in the call, variable completion will show up only when user enters ${