Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ca add variable #347

Merged
merged 10 commits into from
Feb 21, 2025
Merged

Ca add variable #347

merged 10 commits into from
Feb 21, 2025

Conversation

arunvenmany-ibm
Copy link
Contributor

@arunvenmany-ibm arunvenmany-ibm commented Feb 11, 2025 •
edited
Loading

Fixes #69

Also added code changes to

  1. show variable diagnostics if name attribute is empty
  2. show variable diagnostics if value or defaultValue attribute is specified and empty( this will show diagnostic automatically to newly added quickfix variable

@arunvenmany-ibm
Copy link
Contributor Author

Attaching recording to show "Add Variable" codeaction behavior

Screen.Recording.2025-02-11.at.10.07.48.AM.mov

@arunvenmany-ibm arunvenmany-ibm merged commit d3c5dbe into OpenLiberty:main Feb 21, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cherylking cherylking cherylking approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide quick fix for undefined property reference in server.xml
2 participants
@arunvenmany-ibm @cherylking