Refactor the automated UI tests for easier maintenance #1083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paul Gooderham <[email protected]>
Signed-off-by: Paul Gooderham <[email protected]>
Signed-off-by: Paul Gooderham <[email protected]>
turkeylurkey
force-pushed
the
refactor-IT
branch
from
1582c4a
to
72304f3
Compare
turkeylurkey
requested review from
TrevCraw,
anusreelakshmi934,
mrglavas and
aparnamichael
Signed-off-by: Paul Gooderham <[email protected]>
|
@turkeylurkey I noticed this PR has moved away from an object oriented solution to state managed by static fields. When you were describing the refactoring I had imagined the state would be managed by an instance of the test class (e.g. set in the constructor) or some other object. Imagine a JUnit test runner that runs test cases in parallel. How would that work now? I don't think it would. Maybe that's not the best example for tests which drive a single UI but wondering if you considered keeping this OO before you went down this path. |
Signed-off-by: Paul Gooderham <[email protected]>
Signed-off-by: Paul Gooderham <[email protected]>
Signed-off-by: Paul Gooderham <[email protected]>
|
@mrglavas Good points. I made the tests more OO. |
src/test/java/io/openliberty/tools/intellij/it/GradleSingleModMPProjectTest.java
Show resolved
Hide resolved
mrglavas
approved these changes
Nov 8, 2024
anusreelakshmi934
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new copyright headers specify year 2023 which is the correct year.
Fixes #1082