-
Notifications
You must be signed in to change notification settings - Fork 70
Add fixture coemar/relite-led-variwhite-hd
#4784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Export files validity(Output of test script Test the exported files of selected fixtures against the plugins' export tests. ✔️ coemar / relite-led-variwhite-hd: d-light / attributes-correctness
✔️ coemar / relite-led-variwhite-hd: dmxcontrol3 / channel-numbers
✔️ coemar / relite-led-variwhite-hd: dragonframe / json-schema-conformity
✔️ coemar / relite-led-variwhite-hd: millumin / json-schema-conformity
❌ coemar / relite-led-variwhite-hd: qlcplus_4.12.2 / fixture-tool-validation
❌ coemar / relite-led-variwhite-hd: qlcplus_4.12.2 / xsd-schema-conformity
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good for the 2-ch mode, but the fixture has about 6 other more complex modes (depending on whether it's the MK1 or not) which are not mapped here yet.
{ | ||
"$schema": "https://raw.githubusercontent.com/OpenLightingProject/open-fixture-library/master/schemas/fixture.json", | ||
"name": "ReLite LED VariWhite HD+", | ||
"categories": ["Color Changer", "Effect", "Dimmer"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"categories": ["Color Changer", "Effect", "Dimmer"], | |
"categories": ["Other"], |
@@ -0,0 +1,52 @@ | |||
{ | |||
"$schema": "https://raw.githubusercontent.com/OpenLightingProject/open-fixture-library/master/schemas/fixture.json", | |||
"name": "ReLite LED VariWhite HD+", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"name": "ReLite LED VariWhite HD+", | |
"name": "ReLite LED VariWhite HD+", |
coemar/relite-led-variwhite-hd
Fixture warnings / errors
Thank you SW!