Skip to content

Add fixture coemar/relite-led-variwhite-hd #4784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

FloEdelmann
Copy link
Member

  • Add fixture coemar/relite-led-variwhite-hd

Fixture warnings / errors

  • coemar/relite-led-variwhite-hd
    • ❌ Category 'Color Changer' invalid since there are no ColorPreset and less than two ColorIntensity capabilities and no Color wheel slots.

Thank you SW!

@FloEdelmann FloEdelmann added new-fixture Request or implementation to add a new fixture definition. via-editor Opened via the editor on the open-fixture-library.org website. labels Apr 8, 2025
Copy link

github-actions bot commented Apr 8, 2025

Export files validity

(Output of test script tests/github/exports-valid.js.)

Test the exported files of selected fixtures against the plugins' export tests.
You can run a plugin's export tests by executing:
$ node cli/run-export-test.js -p <plugin name> <fixtures>

✔️ coemar / relite-led-variwhite-hd: d-light / attributes-correctness
  • ✔️ coemar/relite-led-variwhite-hd-2ch.xml
✔️ coemar / relite-led-variwhite-hd: dmxcontrol3 / channel-numbers
  • ✔️ coemar-relite-led-variwhite-hd-2ch.xml
✔️ coemar / relite-led-variwhite-hd: dragonframe / json-schema-conformity
  • ✔️ coemar/relite-led-variwhite-hd.json
  • ✔️ manufacturers.json
✔️ coemar / relite-led-variwhite-hd: millumin / json-schema-conformity
  • ✔️ coemar/relite-led-variwhite-hd.json
coemar / relite-led-variwhite-hd: qlcplus_4.12.2 / fixture-tool-validation
  • ❌ fixtures/Coemar-ReLite-LED-VariWhite-HD+.qxfNamespace(map=False, convert=None, validate=['.']) Starting validation ./manufacturer/fixture.qxf: Invalid physical dimensions detected 1 definitions processed. 1 errors detected
coemar / relite-led-variwhite-hd: qlcplus_4.12.2 / xsd-schema-conformity
  • ❌ fixtures/Coemar-ReLite-LED-VariWhite-HD+.qxfElement '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Weight': [facet 'minExclusive'] The value '0' must be greater than '0'.
    Element '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Width': '0' is not a valid value of the atomic type 'xs:positiveInteger'.
    Element '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Height': '0' is not a valid value of the atomic type 'xs:positiveInteger'.
    Element '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Depth': '0' is not a valid value of the atomic type 'xs:positiveInteger'.

Copy link
Contributor

@kengruven kengruven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good for the 2-ch mode, but the fixture has about 6 other more complex modes (depending on whether it's the MK1 or not) which are not mapped here yet.

{
"$schema": "https://raw.githubusercontent.com/OpenLightingProject/open-fixture-library/master/schemas/fixture.json",
"name": "ReLite LED VariWhite HD+",
"categories": ["Color Changer", "Effect", "Dimmer"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"categories": ["Color Changer", "Effect", "Dimmer"],
"categories": ["Other"],

@@ -0,0 +1,52 @@
{
"$schema": "https://raw.githubusercontent.com/OpenLightingProject/open-fixture-library/master/schemas/fixture.json",
"name": "ReLite LED VariWhite HD+",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"name": "ReLite LED VariWhite HD+",
"name": "ReLite LED VariWhite HD+",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-fixture Request or implementation to add a new fixture definition. via-editor Opened via the editor on the open-fixture-library.org website.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants