Skip to content

Improve type error messages to show types instead of values #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jpfeuffer wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Improve type error messages to show types instead of values #226

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions autowrap/CodeGenerator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -991,7 +991,8 @@ def _create_overloaded_method_decl(
method_code.add(
""" else:
| raise
+ Exception('can not handle type of %s' % (args,))"""
+ Exception('can not handle types %s as arguments for function %s()' % (tuple(type(arg).__name__ for arg in args), '$py_name'))""",
locals(),
)
return method_code, typestub_code

Expand Down Expand Up @@ -1126,7 +1127,7 @@ def _create_fun_decl_and_input_conversion(self, code, py_name, method, is_free_f
cleanups.append(cleanup)
call_args.append(call_as)
in_types.append(t)
checks.append((n, converter.type_check_expression(t, n)))
checks.append((n, converter.type_check_expression(t, n), py_typing_type))

# Step 1: create method decl statement
if not is_free_fun and not method.is_static:
Expand Down Expand Up @@ -1204,8 +1205,8 @@ def _create_fun_decl_and_input_conversion(self, code, py_name, method, is_free_f

# Step 2a: create code which converts python input args to c++ args of
# wrapped method
for n, check in checks:
code.add(" assert %s, 'arg %s wrong type'" % (check, n))
for n, check, expected_type in checks:
code.add(" assert %s, 'arg %s wrong type (expected %s)'" % (check, n, expected_type))
# Step 2b: add any more sophisticated conversion code that was created
# above:
for conv_code in input_conversion_codes:
Expand Down