Skip to content

Fix ArrayWrapper inlining to go to pyx only, not pxd #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jpfeuffer merged 3 commits into from
Dec 30, 2025
Merged

Fix ArrayWrapper inlining to go to pyx only, not pxd #228

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
abfbaa2
Add std::hash support and disable ArrayWrapper inlining
timosachsenberg Dec 30, 2025
11e5f21
Fix ArrayWrapper inlining to go to pyx only, not pxd
timosachsenberg Dec 30, 2025
c0917e9
Merge branch 'master' into feature/arraywrapper-pyx-only
timosachsenberg Dec 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions autowrap/CodeGenerator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2133,11 +2133,11 @@ def create_std_cimports(self):
code.add(stmt)

self.top_level_code.append(code)

# If numpy is enabled, inline the ArrayWrapper/ArrayView classes
if self.include_numpy:
self.inline_array_wrappers()

return code

def inline_array_wrappers(self):
Expand Down Expand Up @@ -2175,8 +2175,10 @@ def inline_array_wrappers(self):
""")
# Add the wrapper code directly
code.add(wrapper_code_str)

self.top_level_code.append(code)

# Add to top_level_pyx_code so ArrayWrappers go to pyx only, not pxd
# This avoids conflicts when the project already has ArrayWrapper definitions
self.top_level_pyx_code.append(code)

def create_includes(self):
code = Code()
Expand Down