Merged
Conversation
…T strategy tests refactor: update fetch mock to use global as any in song webhook service tests fix: return ArrayBuffer instead of Buffer in file service
…e and browser environments
…nto feature/bun
…nto feature/bun
…d updating type references
… client configuration
Bentroen
reviewed
May 2, 2025
Member
There was a problem hiding this comment.
Hi! Was the removal of the assets folder from src necessary? Be sure it doesn't break loading of the font/note block sprite when generating the thumbnail server-side :)
Member
Author
There was a problem hiding this comment.
I moved the assets folder outside the src directory to better align with common project structures where static or shared resources are separated from the application code logic, similar to how the public folder is treated in frontend and backend projects. This helps keep the source code focused and makes asset management more centralized and intuitive.
I’ve ensured that all paths referencing fonts and the note block sprite used in thumbnail generation are updated accordingly.
…sController tests
…ve mock implementations
… jest.spyOn with spyOn
…d improve error handling
…nto feature/bun
… .eslintrc.js with .eslintrc.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant changes to the project, including a migration from
pnpm/nodetobun, enhancements to build and runtime configurations, and various codebase improvements.Migration to
bun:package.jsonscripts to usebuninstead ofpnpmfor tasks such as development, building, and testing. Addedconcurrentlyto run the backend and frontend simultaneously for development.Production build:
For running in production with
bun, the following command is used:Nest backend
This will build the NestJS backend for production.
This will start the NestJS production build.
Next frontend
This will build the Next.js frontend for production.
This will start the Next.js production build.