OPG-497: Perf DS, node configurable limits, node label search #1051
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Contributor
|
LGTM! |
sbernabe1
approved these changes
Oct 16, 2025
marshallmassengill
approved these changes
Oct 16, 2025
Contributor
marshallmassengill
left a comment
marshallmassengill
left a comment
There was a problem hiding this comment.
I poked at the code. It looks reasonable to me. I am all for getting this out there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When performing a Performance Datasource attribute query, the Node dropdown has a limit of 1000 items in the response.
If there are thousands of nodes, the user won't ever see all of them in the dropdown and will not be able to select it.
This PR does 2 things.
When configuring the Performance Datasource, there's a new option, "Override attribute query node limit". The default limit of nodes searched is 1000, but you can change it to another value, or set it to unlimited. Note, there may be a performance issue in this case and the UI may not really be able to handle over 1000 entries.
You can enter a query term in the Node dropdown and a case-sensitive "LIKE" query will be made; this is basically an autocomplete style feature, which searches any part of a node label. Note, there's a basic issue we have with all FIQL queries that they are case-sensitive.
External References