Add Chat-Bubbles Feature by Wueffi · Pull Request #29 · OpenRedstoneEngineers/ChattORE

Wueffi · 2026-04-26T18:21:20Z

This PR adds what the title says 🧋

paulikauro

Cool! One general comment: "Chat-Bubble" -> "chat bubble". Some simplifications and a few things to think about in code comments

paulikauro

Nice work! There are some ACF things that would be good to address at this point:

commands should take target: OnlinePlayer
Bubble should get its own ACF context (like mentioned previously)
additionally, the Bubble context should have a flag for checking bubble ownership. Then you can simply do @Flag(FLAG_BUBBLE_OWNED) bubble: Bubble whenever a command needs the sender to be an owner of a bubble (delete, kick, setPrivate). (There FLAG_BUBBLE_OWNED is just a constant string; compare to eg UserCache.COMPLETION_USERNAMES, except this one doesn't have to be public)
Once implemented, these will make the commands shorter and nicer to read, plus there'll be less duplication :)

Wueffi · 2026-05-03T16:06:26Z

Review requested!

paulikauro

Nice, some small details still and a few bigger suggestions

`sender` is never Player, so the else branch was always taken. Now every error will also get the info prefix added to it. In the future, a sendError may be useful to add.

Wueffi · 2026-05-04T16:31:47Z

I'd like to formally request a review from the great PaukkuPalikka again

Wueffi · 2026-05-25T14:47:34Z

I'd like to formally request a review from the great PaukkuPalikka or the great Nickster again

paulikauro

Looks good! A couple minor things in the comments. I think the only remaining thing we should address is shout going thru the chat filter

paulikauro · 2026-05-25T15:27:38Z

I forgot shout already did its thing. So the thought here would be to reserve PlayerChatEvent only for players actually typing messages in chat (so no creating and dispatching that event inside the plugin), and instead call whatever functions necessary directly from /shout. That way we don't have to have a set of shouting players and check in the event handler. I think shout should also be in the Bubble file, but it's fine to keep it in Chat for now if it creates dependency problems to move it back into the Bubble file.

…hings!

- bubble list only shows bubbles you can access, unless you have the manage permission - some commands (join) now let you join if you can't access the bubble if you have the manage permission

Append causes some styles to get inherited where they aren't welcome. textOfChildren is the right way to concatenate components.

…to mail

Wueffi and others added 2 commits April 26, 2026 20:17

Add Chat-Bubbles Feature

994057e

Remove unnecessary (mb) line

50c0923

paulikauro requested changes Apr 26, 2026

View reviewed changes

Ready for another review round!

419034b

Wueffi requested a review from paulikauro April 27, 2026 13:50

paulikauro reviewed Apr 27, 2026

View reviewed changes

Comment thread chattore/src/main/kotlin/feature/Bubble.kt Outdated

paulikauro reviewed Apr 27, 2026

View reviewed changes

Comment thread chattore/src/main/kotlin/feature/Bubble.kt Outdated

paulikauro requested changes Apr 27, 2026

View reviewed changes

Comment thread chattore/src/main/kotlin/Messenger.kt Outdated

Comment thread chattore/src/main/kotlin/feature/Bubble.kt Outdated

Wueffi added 3 commits April 27, 2026 19:18

Changes!

378d034

Changes!

1b3effb

Merge remote-tracking branch 'bubbles/master'

828c84d

paulikauro reviewed Apr 27, 2026

View reviewed changes

Comment thread chattore/src/main/kotlin/feature/Bubble.kt Outdated

The review of the review

250be24

Wueffi requested a review from paulikauro May 3, 2026 16:04

paulikauro requested changes May 3, 2026

View reviewed changes

Wueffi and others added 2 commits May 4, 2026 18:28

Another round of review

7a48000

Fix handleCommandException

62418d2

`sender` is never Player, so the else branch was always taken. Now every error will also get the info prefix added to it. In the future, a sendError may be useful to add.

Wueffi requested a review from paulikauro May 4, 2026 16:31

paulikauro reviewed May 4, 2026

View reviewed changes

Comment thread chattore/src/main/kotlin/feature/Bubble.kt Outdated

Comment thread chattore/src/main/kotlin/Messenger.kt Outdated

paulikauro added 2 commits May 4, 2026 23:16

Refactor sender and prefix construction into one method

06c79bd

Small simplification

7cf002b

paulikauro reviewed May 4, 2026

View reviewed changes

Comment thread chattore/src/main/kotlin/Messenger.kt Outdated

Remove circular dependency as best as possible

0caa0a4

Wueffi requested a review from paulikauro May 25, 2026 14:47

paulikauro reviewed May 25, 2026

View reviewed changes

Comment thread chattore/src/main/kotlin/feature/Bubble.kt Outdated

Comment thread chattore/src/main/kotlin/feature/Bubble.kt Outdated

Comment thread chattore/src/main/kotlin/feature/Bubble.kt Outdated

Make shouting go through chat confirmations and fix two other small t…

74a76ae

…hings!

paulikauro added 30 commits June 11, 2026 08:59

Add sendError and recolor info messages

1d5bfb5

Prevent confirmations from proceeding when bubble no longer exists

a129464

Handle global chat confirmations uniformly

f71d89a

Bump version

9600c18

Small cleanups

2a383bf

Move shout back to Bubble.kt and echo message when global chat disabled

32d45b7

Refactor spying to encapsulate spy prefix into Spying.kt

b0a202d

Use bubble manager permission more in commands

bc6881f

- bubble list only shows bubbles you can access, unless you have the manage permission - some commands (join) now let you join if you can't access the bubble if you have the manage permission

Use UserCache when listing bubble participants

feb7ea6

Add bubble members to invite, cleanup

4f44c9e

Move some command completions into better locations

944119d

Add chat confirmations to DM

f30c534

Extract chat confirmations into their own file

bcac587

Cache settings in memory to reduce database traffic

afd0950

Separate spying into command and social spy

c8d5d1d

Add /msg to social spy

8983b98

Compress Message.kt

dbf4a7b

Make BUBBLE_OWNED consistent in casing with other constants

523f287

Do not show syntax when not in a bubble

1e41f4d

Replace Component#append with Component#textOfChildren

121ce6d

Append causes some styles to get inherited where they aren't welcome. textOfChildren is the right way to concatenate components.

Bubble create and invite take list of players to invite

4db62f3

Refuse invites to public bubbles

6583432

Small refactor

fd19901

Move setting default values into Setting class

0c9a6a8

Update Bubble command descriptions and README

756ff8b

Optimize imports

09f8703

Enforce more trailing commas

222c5c4

Add .kotlin to gitignore

984d0b5

Add chat confirmations to funcommands, helpop, mail and player profile

722a029

Fix chat confirmations having stale Player objects and add socialspy …

b5ad8c2

…to mail

Conversation

Wueffi commented Apr 26, 2026

Uh oh!

paulikauro left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

paulikauro left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Wueffi commented May 3, 2026

Uh oh!

paulikauro left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Wueffi commented May 4, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Wueffi commented May 25, 2026

Uh oh!

paulikauro left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

paulikauro commented May 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants