Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove open in new tab for links #210

Closed
3 tasks
tapaswenipathak opened this issue Dec 24, 2017 · 5 comments
Closed
3 tasks

Remove open in new tab for links #210

tapaswenipathak opened this issue Dec 24, 2017 · 5 comments
Labels
Difficulty: Easy first-timers-only Type: Enhancement

Comments

@tapaswenipathak
Copy link
Member

Remove target=_blank from, for

  • Request a session
  • Contests
  • Journey
Logan1x added a commit to Logan1x/OpenSourceHelpCommunity.github.io that referenced this issue Dec 27, 2017
@Logan1x
Fixed OpenSourceHelpCommunity#210
55f51c3
@Logan1x Logan1x mentioned this issue Dec 27, 2017
Closed
2 tasks
@aaronmaynard aaronmaynard mentioned this issue Dec 30, 2017
Closed
2 tasks
@Nickatak
Copy link
Contributor

Nickatak commented Jan 7, 2018

Hello! I saw that the above two PR's were closed due to non-first-timers (still, it was awesome seeing an example of a solid PR). Do you mind if I work on this? :D

@anubhakushwaha
Copy link
Member

@Nickatak Yes go ahead.

@Nickatak Nickatak mentioned this issue Jan 9, 2018
Merged
9 tasks
tapaswenipathak added a commit that referenced this issue Jan 13, 2018
@tapaswenipathak
Merge pull request #227 from Nickatak/predev
0186490 
Fix for #210: Removed target attribute from some links.
@nirmaldalmia
Copy link

I would like to work on this issue. I am new to open source but I've been working on websites for quite some time now. Let me know if the issue is still open.
Do I have to delete all the target="_blank" tags from the page or only 3 mentioned above?

@tapaswenipathak
Copy link
Member Author

👋 @nirmaldalmia from Request a session, Contests and Journey.

@nirmaldalmia
Copy link

@tapasweni-pathak Is the issue already solved? Because I don't see any target="_blank" in the above mentioned tags.
Also went through the PR submitted before my comment which says the issue is resolved.
Let me know if there is still anything I can do.

@catherinefromont catherinefromont mentioned this issue Jun 20, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Difficulty: Easy first-timers-only Type: Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed #210 Logan1x/OpenSourceHelpCommunity.github.io
Removed "_blank"
4 participants
@tapaswenipathak @Nickatak @anubhakushwaha @nirmaldalmia