Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #210: Removed target attribute from some links. #227

Merged
merged 1 commit into from
Jan 13, 2018
Merged

Conversation

Nickatak
Copy link
Contributor

@Nickatak Nickatak commented Jan 9, 2018

Checklist

  • My branch is up-to-date with the upstream predev branch.
  • I have added necessary documentation (if appropriate).

Which issue does this PR fix?:
Fixes issue #210 (links undesirably opening in new tab).

This PR removes the target attribute entirely for each anchor tag mentioned in issue 210 inside /oshc/main/templates/base.html. To allow for consistency, I opted to completely remove the target attribute so that it matches other in-tab-opening links on the same page. This removal has been applied to the following links:

  • Request a Session (under the Session drop-down of the nav-bar)
  • Contests (on the nav-bar)
  • Journey (in the footer, the flower-box emblem)

Why do we need this PR?:
UI/UX alteration to provide for favorable user interaction (altered links don't open in new tab when they don't need to).

Testing instructions:
I have taken the following steps, and am leaving them unchecked below for you to use:

  • Create a virtual environment (and activate it)
  • Clone the forked repository.
  • Update to predev branch if you haven't [I don't know whether git saved that or not] (git fetch https://github.com/OpenSourceHelpCommunity/OpenSourceHelpCommunity.github.io/predev)
  • Install pre-commit
  • collectstatic (python manage.py collectstatic)
  • Run development server (python manage.py runserver)
  • Click on altered links in order to verify desired functionality.

TODOs (if any):
None

A picture of a cute animal (not mandatory but encouraged):
Old but good:
pzhjedp

@coveralls
Copy link

Coverage Status

Coverage remained the same at 72.269% when pulling 4cf4563 on Nickatak:predev into 850a09f on OpenSourceHelpCommunity:predev.

Copy link
Member

@tapaswenipathak tapaswenipathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@tapaswenipathak tapaswenipathak merged commit 0186490 into OpenSourceHelpCommunity:predev Jan 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants