This fixes #150 #154

rudr4x5h · 2017-10-18T15:45:25Z

Checklist

My branch is up-to-date with the upstream develop branch.
I have added necessary documentation (if appropriate).

Which issue does this PR fix?: fixes #150

coveralls · 2017-10-18T15:46:35Z

Coverage remained the same at 69.474% when pulling 335d99e on d3vil0p3r:thank_fix into 2a0e5fd on OpenSourceHelpCommunity:predev.

vaibhavsingh97

LGTM!! 🚀

tapaswenipathak · 2017-10-20T15:47:21Z

oshc/main/templates/contest_submission.html

-      <h1 class="display-3">Thank You!</h1>
-      <p class="lead"><strong>Your contest has been submitted for review.</strong></p>
+      <h1 class="display-3 text-center">Thank you!</h1>
+      <p class="lead text-center"><strong>Your contest has been submitted for review.</strong></p>


This isn't working on my local or on a trial deployment. Can you please share screenshots?

Sure ma'am, here's the screenshot of my local deployment.

If you check this is what the current status is.

I added few more words in the description of the issue. By center I meant, vertically and horizontally in the center of the page, somewhere in the middle.

@tapasweni-pathak it's done, have a look.

coveralls · 2017-10-20T18:14:37Z

Coverage decreased (-1.9%) to 67.619% when pulling 0688d89 on d3vil0p3r:thank_fix into 2a0e5fd on OpenSourceHelpCommunity:predev.

coveralls · 2017-10-20T18:29:01Z

Coverage decreased (-1.9%) to 67.619% when pulling 750c966 on d3vil0p3r:thank_fix into 2a0e5fd on OpenSourceHelpCommunity:predev.

tapaswenipathak · 2017-10-21T01:40:01Z

oshc/main/static/main/css/app.css

+
+.subtitle {
+  margin: 0;
+}


👍

Can you please squash the commits into one, then we are good to go with this one! 🚀

@tapasweni-pathak done 👍

Not yet :( . Add a commit message Move confirmation text to the center (v,h).

@tapasweni-pathak check it now 😄

tapaswenipathak · 2017-10-21T01:47:23Z

oshc/main/templates/contest_submission.html

      <hr>
-      <p class="lead">
+      <p class="lead text-center">


Also you can remove all text-center but on the first div here.

@tapasweni-pathak done 👍

coveralls · 2017-10-21T03:28:19Z

Coverage decreased (-1.9%) to 67.619% when pulling 6eb0fa4 on d3vil0p3r:thank_fix into 2a0e5fd on OpenSourceHelpCommunity:predev.

coveralls · 2017-10-21T03:37:31Z

Coverage remained the same at 67.619% when pulling 396c567 on d3vil0p3r:thank_fix into ae7d124 on OpenSourceHelpCommunity:predev.

coveralls · 2017-10-21T06:43:30Z

Coverage remained the same at 67.619% when pulling 3b4d70e on d3vil0p3r:thank_fix into ae7d124 on OpenSourceHelpCommunity:predev.

tapaswenipathak · 2017-10-21T07:08:38Z

oshc/main/templates/contest_submission.html

-      <h1 class="display-3">Thank You!</h1>
-      <p class="lead"><strong>Your contest has been submitted for review.</strong></p>
+  <div class="container text-center vcenter">
+      <h1 class="display-3 text-center">Thank you!</h1>


These text-centers came back. :) Only the first one is required.

@tapasweni-pathak fixed 👍

coveralls · 2017-10-21T08:05:29Z

Coverage remained the same at 67.619% when pulling 26679fa on d3vil0p3r:thank_fix into ae7d124 on OpenSourceHelpCommunity:predev.

coveralls · 2017-10-21T08:11:23Z

Coverage remained the same at 67.619% when pulling 8c1d068 on d3vil0p3r:thank_fix into ae7d124 on OpenSourceHelpCommunity:predev.

rudr4x5h · 2017-10-22T12:58:06Z

Finally 😄 👍

vaibhavsingh97 added the status: Needs Review label Oct 19, 2017

vaibhavsingh97 approved these changes Oct 19, 2017

View reviewed changes

tapaswenipathak requested changes Oct 20, 2017

View reviewed changes

tapaswenipathak removed the status: Needs Review label Oct 20, 2017

tapaswenipathak requested changes Oct 21, 2017

View reviewed changes

rudr4x5h force-pushed the thank_fix branch from 6eb0fa4 to 396c567 Compare October 21, 2017 03:36

rudr4x5h force-pushed the thank_fix branch from 396c567 to 3b4d70e Compare October 21, 2017 06:42

tapaswenipathak requested changes Oct 21, 2017

View reviewed changes

rudr4x5h force-pushed the thank_fix branch from 3b4d70e to 26679fa Compare October 21, 2017 08:04

Moved confirmation text to the center (v, h)

8c1d068

rudr4x5h force-pushed the thank_fix branch from 26679fa to 8c1d068 Compare October 21, 2017 08:10

tapaswenipathak merged commit 184bed4 into OpenSourceHelpCommunity:predev Oct 21, 2017

rudr4x5h deleted the thank_fix branch October 22, 2017 12:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

This fixes #150 #154

This fixes #150 #154

rudr4x5h commented Oct 18, 2017

coveralls commented Oct 18, 2017

vaibhavsingh97 left a comment

tapaswenipathak Oct 20, 2017

rudr4x5h Oct 20, 2017

tapaswenipathak Oct 20, 2017

rudr4x5h Oct 20, 2017

coveralls commented Oct 20, 2017

coveralls commented Oct 20, 2017

tapaswenipathak Oct 21, 2017

rudr4x5h Oct 21, 2017

tapaswenipathak Oct 21, 2017

rudr4x5h Oct 21, 2017

tapaswenipathak Oct 21, 2017 •

edited

Loading

rudr4x5h Oct 21, 2017

coveralls commented Oct 21, 2017

coveralls commented Oct 21, 2017

coveralls commented Oct 21, 2017

tapaswenipathak Oct 21, 2017 •

edited

Loading

rudr4x5h Oct 21, 2017

coveralls commented Oct 21, 2017

coveralls commented Oct 21, 2017

rudr4x5h commented Oct 22, 2017

This fixes #150 #154

This fixes #150 #154

Conversation

rudr4x5h commented Oct 18, 2017

coveralls commented Oct 18, 2017

vaibhavsingh97 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coveralls commented Oct 20, 2017

coveralls commented Oct 20, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tapaswenipathak Oct 21, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coveralls commented Oct 21, 2017

coveralls commented Oct 21, 2017

coveralls commented Oct 21, 2017

tapaswenipathak Oct 21, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coveralls commented Oct 21, 2017

coveralls commented Oct 21, 2017

rudr4x5h commented Oct 22, 2017

tapaswenipathak Oct 21, 2017 •

edited

Loading

tapaswenipathak Oct 21, 2017 •

edited

Loading