Changed "View Session" link URL#218
Closed
TeddyCho wants to merge 1 commit intoOpenSourceHelpCommunity:predevfrom
TeddyCho:predev
Closed
Changed "View Session" link URL#218TeddyCho wants to merge 1 commit intoOpenSourceHelpCommunity:predevfrom TeddyCho:predev
TeddyCho wants to merge 1 commit intoOpenSourceHelpCommunity:predevfrom
TeddyCho:predev
Conversation
The previous for the "View Session" link was https://www.youtube.com/channel/UC1_IAby-9me3iICtxuiDL5Q and now it is https://www.youtube.com/channel/UC1_IAby-9me3iICtxuiDL5Q/videos/ to address Issue #213.
anubhakushwaha
requested review from
jarifibrahim
and removed request for
jarifibrahim
| <a href="#" class="dropdown-toggle" data-toggle="dropdown">Sessions <span class="caret"></span></a> | ||
| <ul class="dropdown-menu" role="menu"> | ||
| <li><a href="https://www.youtube.com/channel/UC1_IAby-9me3iICtxuiDL5Q" target="_blank">View Session</a></li> | ||
| <li><a href="https://www.youtube.com/channel/UC1_IAby-9me3iICtxuiDL5Q/videos/" target="_blank">View Session</a></li> |
Member
There was a problem hiding this comment.
There is a minor glitch here, the issue needs the url to be updated to https://www.youtube.com/channel/UC1_IAby-9me3iICtxuiDL5Q/videos and not to https://www.youtube.com/channel/UC1_IAby-9me3iICtxuiDL5Q/videos/.
Results are different 👇
Need to have the second one.
tapaswenipathak
requested changes
Dec 28, 2017
Member
There was a problem hiding this comment.
👋 @TeddyCho, Can you please fix the link and update this pr?
Member
|
Closing this as it is fixed by #225. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous for the "View Session" link was https://www.youtube.com/channel/UC1_IAby-9me3iICtxuiDL5Q and now it is https://www.youtube.com/channel/UC1_IAby-9me3iICtxuiDL5Q/videos/ to address Issue #213.
Checklist
predevbranch.Which issue does this PR fix?: fixes #213
This PR corrects the URL of the "View Session" link as described in issue #213.
Why do we need this PR?:
If relevant, please include a screenshot.
Demo (optional):
Some tips for you to write the instructions:
Testing instructions:
If there is any work still left to do, please add it here.
TODOs (if any):
A picture of a cute animal (not mandatory but encouraged):