-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the 0BSD license #65
Conversation
Signed-off-by: Gary O'Neall <[email protected]>
@webmink please review. This was generated using a python script pulling the data from the SPDX JSON metadata. If you see any issues, let me know and I will update the script before attacking the other missing licenses. |
I think the process should be decided by whoever is in charge of stewarding the OSI license approval process (independently from the API). Rationale: we shouldn't risk stray PR approvals that would make the API start announcing to the world that a license is OSI-approved when it isn't. For this part, I think requiring from licensing lead a comment in the relevant PR saying it is OK to add/remove/update a given license would be enough. |
@zacchiro @webmink Thanks for following up on the process. I await this PR to be merged before proceeding with the other PR's. One question - would you prefer me to submit a separate PR for each fix or would you like me to batch them into common issue (e.g. add missing SPDX ID's for existing licenses all in one PR)? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok to add 0BSD to the repo.
@paultag Please can you merge this one; I can do the ones that are all green but lack the experience with the ones that need prior actions. |
Signed-off-by: Gary O'Neall <[email protected]>
I added a commit to remove the first line of the text after comparing the plain text with the OSI website. The plain text now matches the OSI website text. |
I ran into some validation errors on the 0BSD license - change to draft until it passes validation. |
Signed-off-by: Gary O'Neall <[email protected]>
Signed-off-by: Gary O'Neall <[email protected]>
OK - this now passes validation |
Signed-off-by: Gary O'Neall <[email protected]>
@pchestek Note that I made the following changes since your review:
I should be finished making changes unless any of the reviews find additional issues. |
If the files from this PR is used to generate the website in the future, note that is is missing the "notes" text:
If this text is supposed to be in the JSON file, please let me know which field(s) need to be updated so I can add those in the future. |
Add the 0BSD license which is present on the OSI website but not present in the repo.
Partially resolves issue #62
Signed-off-by: Gary O'Neall [email protected]