Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the 0BSD license #65

Merged
merged 5 commits into from
Oct 14, 2021
Merged

Add the 0BSD license #65

merged 5 commits into from
Oct 14, 2021

Conversation

goneall
Copy link
Contributor

@goneall goneall commented Sep 15, 2021

Add the 0BSD license which is present on the OSI website but not present in the repo.

Partially resolves issue #62

Signed-off-by: Gary O'Neall [email protected]

Signed-off-by: Gary O'Neall <[email protected]>
@goneall
Copy link
Contributor Author

goneall commented Sep 15, 2021

@webmink please review. This was generated using a python script pulling the data from the SPDX JSON metadata.

If you see any issues, let me know and I will update the script before attacking the other missing licenses.

@webmink
Copy link
Member

webmink commented Sep 26, 2021

@paultag @zacchiro First test case! How would you like us all to handle this?

@webmink webmink requested a review from a team September 26, 2021 12:57
@zacchiro
Copy link
Contributor

zacchiro commented Sep 26, 2021

I think the process should be decided by whoever is in charge of stewarding the OSI license approval process (independently from the API). Rationale: we shouldn't risk stray PR approvals that would make the API start announcing to the world that a license is OSI-approved when it isn't. For this part, I think requiring from licensing lead a comment in the relevant PR saying it is OK to add/remove/update a given license would be enough.

@webmink webmink linked an issue Sep 26, 2021 that may be closed by this pull request
23 tasks
@goneall
Copy link
Contributor Author

goneall commented Sep 26, 2021

@zacchiro @webmink Thanks for following up on the process. I await this PR to be merged before proceeding with the other PR's.

One question - would you prefer me to submit a separate PR for each fix or would you like me to batch them into common issue (e.g. add missing SPDX ID's for existing licenses all in one PR)?

Copy link

@pchestek pchestek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to add 0BSD to the repo.

@webmink
Copy link
Member

webmink commented Sep 29, 2021

@paultag Please can you merge this one; I can do the ones that are all green but lack the experience with the ones that need prior actions.

@goneall
Copy link
Contributor Author

goneall commented Sep 30, 2021

I added a commit to remove the first line of the text after comparing the plain text with the OSI website.

The plain text now matches the OSI website text.

@goneall goneall marked this pull request as draft September 30, 2021 20:42
@goneall
Copy link
Contributor Author

goneall commented Sep 30, 2021

I ran into some validation errors on the 0BSD license - change to draft until it passes validation.

@goneall
Copy link
Contributor Author

goneall commented Sep 30, 2021

OK - this now passes validation

@goneall goneall marked this pull request as ready for review September 30, 2021 20:58
@goneall
Copy link
Contributor Author

goneall commented Sep 30, 2021

@pchestek Note that I made the following changes since your review:

  • Removed the first line of the license text to match the OSI website
  • Added a link to the OSI text

I should be finished making changes unless any of the reviews find additional issues.

@goneall
Copy link
Contributor Author

goneall commented Sep 30, 2021

If the files from this PR is used to generate the website in the future, note that is is missing the "notes" text:

Note: Despite its name, Zero-Clause BSD is an alteration of the ISC license, and is not textually derived from licenses in the BSD family. Zero-Clause BSD was originally approved under the name "Free Public License 1.0.0".

If this text is supposed to be in the JSON file, please let me know which field(s) need to be updated so I can add those in the future.

@webmink webmink mentioned this pull request Oct 1, 2021
@paultag paultag merged commit 5b0abb9 into OpenSourceOrg:master Oct 14, 2021
@goneall goneall mentioned this pull request Oct 14, 2021
23 tasks
@goneall goneall deleted the 0bsd branch November 7, 2021 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing SPDX identifier data
5 participants